Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
client/WikibaseClient.ServiceWiring.php

Summary

Maintainability
D
2 days
Test Coverage

File WikibaseClient.ServiceWiring.php has 942 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare( strict_types = 1 );

use DataValues\Deserializers\DataValueDeserializer;
Severity: Major
Found in client/WikibaseClient.ServiceWiring.php - About 2 days to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        'WikibaseClient.DataTypeDefinitions' => function ( MediaWikiServices $services ): DataTypeDefinitions {
        $baseDataTypes = require __DIR__ . '/../lib/WikibaseLib.datatypes.php';
        $clientDataTypes = require __DIR__ . '/WikibaseClient.datatypes.php';

        $dataTypes = wfArrayPlus2d(
    Severity: Major
    Found in client/WikibaseClient.ServiceWiring.php and 1 other location - About 1 hr to fix
    repo/WikibaseRepo.ServiceWiring.php on lines 473..490

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        'WikibaseClient.TermFallbackCacheFactory' => function ( MediaWikiServices $services ): TermFallbackCacheFactory {
        $settings = WikibaseClient::getSettings( $services );
        return new TermFallbackCacheFactory(
            $settings->getSetting( 'sharedCacheType' ),
            WikibaseClient::getLogger( $services ),
    Severity: Major
    Found in client/WikibaseClient.ServiceWiring.php and 1 other location - About 1 hr to fix
    repo/WikibaseRepo.ServiceWiring.php on lines 1947..1958

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        'WikibaseClient.CompactEntitySerializer' => function ( MediaWikiServices $services ): Serializer {
        $serializerFactoryCallbacks = WikibaseClient::getEntityTypeDefinitions( $services )
            ->get( EntityTypeDefinitions::SERIALIZER_FACTORY_CALLBACK );
        $baseSerializerFactory = WikibaseClient::getCompactBaseDataModelSerializerFactory( $services );
        $serializers = [];
    Severity: Major
    Found in client/WikibaseClient.ServiceWiring.php and 3 other locations - About 45 mins to fix
    repo/WikibaseRepo.ServiceWiring.php on lines 278..289
    repo/WikibaseRepo.ServiceWiring.php on lines 437..448
    repo/WikibaseRepo.ServiceWiring.php on lines 1827..1838

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        'WikibaseClient.ItemAndPropertySource' => function ( MediaWikiServices $services ): EntitySource {
        $itemAndPropertySourceName = WikibaseClient::getSettings( $services )->getSetting( 'itemAndPropertySourceName' );
        $sources = WikibaseClient::getEntitySourceDefinitions( $services )->getSources();
        foreach ( $sources as $source ) {
            if ( $source->getSourceName() === $itemAndPropertySourceName ) {
    Severity: Minor
    Found in client/WikibaseClient.ServiceWiring.php and 1 other location - About 30 mins to fix
    repo/WikibaseRepo.ServiceWiring.php on lines 1445..1455

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        'WikibaseClient.EntityTypeDefinitions' => function ( MediaWikiServices $services ): EntityTypeDefinitions {
        $baseEntityTypes = require __DIR__ . '/../lib/WikibaseLib.entitytypes.php';
        $clientEntityTypes = require __DIR__ . '/WikibaseClient.entitytypes.php';

        $entityTypes = wfArrayPlus2d(
    Severity: Minor
    Found in client/WikibaseClient.ServiceWiring.php and 1 other location - About 30 mins to fix
    repo/WikibaseRepo.ServiceWiring.php on lines 1094..1106

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status