Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
client/data-bridge/src/store/actions.ts

Summary

Maintainability
D
3 days
Test Coverage

File actions.ts has 347 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { DataValue } from '@wmde/wikibase-datamodel-types';
import ApiErrors from '@/data-access/error/ApiErrors';
import SavingError from '@/data-access/error/SavingError';
import { Store } from 'vuex';
import Application, { InitializedApplicationState, SavingState } from '@/store/Application';
Severity: Minor
Found in client/data-bridge/src/store/actions.ts - About 4 hrs to fix

    Function initBridge has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public initBridge(
        information: AppInformation,
    ): Promise<void> {
        this.commit( 'setEditFlow', information.editFlow );
        this.commit( 'setPropertyPointer', information.propertyId );
    Severity: Major
    Found in client/data-bridge/src/store/actions.ts - About 2 hrs to fix

      Function saveBridge has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public async saveBridge(): Promise<unknown> {
        if ( this.state.applicationStatus !== ApplicationStatus.READY ) {
            this.commit( 'addApplicationErrors', [ {
                type: ErrorTypes.APPLICATION_LOGIC_ERROR,
                info: { stack: ( new Error() ).stack },
      Severity: Major
      Found in client/data-bridge/src/store/actions.ts - About 2 hrs to fix

        Function validateBridgeApplicability has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public validateBridgeApplicability(
        path: MainSnakPath,
    ): Promise<unknown> {
        if ( this.state.applicationStatus === ApplicationStatus.SAVED ) {
            // saving edits can transition us from applicable to inapplicable states, but that should not be an error
        Severity: Minor
        Found in client/data-bridge/src/store/actions.ts - About 1 hr to fix

          Function validateBridgeApplicability has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public validateBridgeApplicability(
        path: MainSnakPath,
    ): Promise<unknown> {
        if ( this.state.applicationStatus === ApplicationStatus.SAVED ) {
            // saving edits can transition us from applicable to inapplicable states, but that should not be an error
          Severity: Minor
          Found in client/data-bridge/src/store/actions.ts - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                  return Promise.resolve();
          Severity: Major
          Found in client/data-bridge/src/store/actions.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return this.dispatch( 'addError', [ error ] );
            Severity: Major
            Found in client/data-bridge/src/store/actions.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return this.dispatch( 'addError', [ { type: ErrorTypes.UNSUPPORTED_DATAVALUE_TYPE } ] );
              Severity: Major
              Found in client/data-bridge/src/store/actions.ts - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( this.state.applicationStatus !== ApplicationStatus.READY ) {
            this.commit( 'addApplicationErrors', [ {
                type: ErrorTypes.APPLICATION_LOGIC_ERROR,
                info: { stack: ( new Error() ).stack },
            } ] );
                Severity: Major
                Found in client/data-bridge/src/store/actions.ts and 1 other location - About 2 hrs to fix
                client/data-bridge/src/store/actions.ts on lines 277..283

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 76.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( this.state.applicationStatus !== ApplicationStatus.READY ) {
            this.commit( 'addApplicationErrors', [ {
                type: ErrorTypes.APPLICATION_LOGIC_ERROR,
                info: { stack: ( new Error() ).stack },
            } ] );
                Severity: Major
                Found in client/data-bridge/src/store/actions.ts and 1 other location - About 2 hrs to fix
                client/data-bridge/src/store/actions.ts on lines 263..269

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 76.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public async trackSavingErrorsFallingBackToGenericView(): Promise<void> {
        for ( const error of this.state.applicationErrors ) {
            this.store.$services.get( 'tracker' ).trackSavingUnknownError( error.type );
        }
    }
                Severity: Major
                Found in client/data-bridge/src/store/actions.ts and 1 other location - About 1 hr to fix
                client/data-bridge/src/store/actions.ts on lines 374..378

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 70.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public async trackErrorsFallingBackToGenericView(): Promise<void> {
        for ( const error of this.state.applicationErrors ) {
            this.store.$services.get( 'tracker' ).trackUnknownError( error.type );
        }
    }
                Severity: Major
                Found in client/data-bridge/src/store/actions.ts and 1 other location - About 1 hr to fix
                client/data-bridge/src/store/actions.ts on lines 380..384

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 70.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( snakType !== 'value' ) {
            const error: ApplicationError = {
                type: ErrorTypes.UNSUPPORTED_SNAK_TYPE,
                info: { snakType },
            };
                Severity: Major
                Found in client/data-bridge/src/store/actions.ts and 1 other location - About 1 hr to fix
                client/data-bridge/src/store/actions.ts on lines 243..251

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( datatype !== 'string' ) {
            const error: ApplicationError = {
                type: ErrorTypes.UNSUPPORTED_DATATYPE,
                info: {
                    unsupportedDatatype: datatype,
                Severity: Major
                Found in client/data-bridge/src/store/actions.ts and 1 other location - About 1 hr to fix
                client/data-bridge/src/store/actions.ts on lines 231..237

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( this.statementModule.getters.dataValueType( path ) !== 'string' ) {
            return this.dispatch( 'addError', [ { type: ErrorTypes.UNSUPPORTED_DATAVALUE_TYPE } ] );
        }
                Severity: Minor
                Found in client/data-bridge/src/store/actions.ts and 1 other location - About 50 mins to fix
                client/data-bridge/src/store/actions.ts on lines 223..225

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( this.statementModule.getters.rank( path ) === 'deprecated' ) {
            return this.dispatch( 'addError', [ { type: ErrorTypes.UNSUPPORTED_DEPRECATED_STATEMENT } ] );
        }
                Severity: Minor
                Found in client/data-bridge/src/store/actions.ts and 1 other location - About 50 mins to fix
                client/data-bridge/src/store/actions.ts on lines 253..255

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status