Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
client/includes/Changes/ChangeRunCoalescer.php

Summary

Maintainability
C
1 day
Test Coverage

Function coalesceRuns has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    private function coalesceRuns( EntityId $entityId, array $changes ) {
        $coalesced = [];

        $currentRun = [];
        $currentUser = null;
Severity: Minor
Found in client/includes/Changes/ChangeRunCoalescer.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method mergeChanges has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function mergeChanges( EntityId $entityId, array $changes ) {
        if ( count( $changes ) === 1 ) {
            return reset( $changes );
        }
Severity: Major
Found in client/includes/Changes/ChangeRunCoalescer.php - About 2 hrs to fix

    Method coalesceRuns has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function coalesceRuns( EntityId $entityId, array $changes ) {
        $coalesced = [];

        $currentRun = [];
        $currentUser = null;
    Severity: Major
    Found in client/includes/Changes/ChangeRunCoalescer.php - About 2 hrs to fix

      Function mergeChanges has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function mergeChanges( EntityId $entityId, array $changes ) {
        if ( count( $changes ) === 1 ) {
            return reset( $changes );
        }
      Severity: Minor
      Found in client/includes/Changes/ChangeRunCoalescer.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return 0;
      Severity: Major
      Found in client/includes/Changes/ChangeRunCoalescer.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status