Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
client/includes/Changes/InjectRCRecordsJob.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method run has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run(): bool {
        $change = $this->getChange();
        $titles = $this->getTitles();

        if ( !$change || $titles === [] ) {
Severity: Minor
Found in client/includes/Changes/InjectRCRecordsJob.php - About 2 hrs to fix

    Function run has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function run(): bool {
        $change = $this->getChange();
        $titles = $this->getTitles();

        if ( !$change || $titles === [] ) {
    Severity: Minor
    Found in client/includes/Changes/InjectRCRecordsJob.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct(
        EntityChangeLookup $changeLookup,
        EntityChangeFactory $changeFactory,
        RecentChangeFactory $rcFactory,
        TitleFactory $titleFactory,
    Severity: Minor
    Found in client/includes/Changes/InjectRCRecordsJob.php - About 1 hr to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              EntityChangeLookup $changeLookup,
        EntityChangeFactory $changeFactory,
        RecentChangeFactory $rcFactory,
        TitleFactory $titleFactory,
        array $params
      Severity: Minor
      Found in client/includes/Changes/InjectRCRecordsJob.php - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status