wikimedia/mediawiki-extensions-Wikibase

View on GitHub
client/includes/DataAccess/Scribunto/WikibaseLibrary.php

Summary

Maintainability
D
2 days
Test Coverage

File WikibaseLibrary.php has 483 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare( strict_types = 1 );

namespace Wikibase\Client\DataAccess\Scribunto;
Severity: Minor
Found in client/includes/DataAccess/Scribunto/WikibaseLibrary.php - About 7 hrs to fix

    WikibaseLibrary has 45 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class WikibaseLibrary extends LibraryBase implements ParserOutputProvider {
    
        /**
         * @var WikibaseLanguageIndependentLuaBindings|null
         */
    Severity: Minor
    Found in client/includes/DataAccess/Scribunto/WikibaseLibrary.php - About 6 hrs to fix

      Method register has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function register() {
              // These functions will be exposed to the Lua module.
              // They are member functions on a Lua table which is private to the module, thus
              // these can't be called from user code, unless explicitly exposed in Lua.
              $lib = [
      Severity: Minor
      Found in client/includes/DataAccess/Scribunto/WikibaseLibrary.php - About 1 hr to fix

        Method newLanguageIndependentLuaBindings has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function newLanguageIndependentLuaBindings(): WikibaseLanguageIndependentLuaBindings {
                $mediaWikiServices = MediaWikiServices::getInstance();
                $settings = WikibaseClient::getSettings( $mediaWikiServices );
                $store = WikibaseClient::getStore( $mediaWikiServices );
                $termsLanguages = WikibaseClient::getTermsLanguages( $mediaWikiServices );
        Severity: Minor
        Found in client/includes/DataAccess/Scribunto/WikibaseLibrary.php - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              private function getLuaFunctionCallTracker(): LuaFunctionCallTracker {
                  if ( !$this->luaFunctionCallTracker ) {
                      $mwServices = MediaWikiServices::getInstance();
                      $settings = WikibaseClient::getSettings( $mwServices );
          
          
          Severity: Major
          Found in client/includes/DataAccess/Scribunto/WikibaseLibrary.php and 1 other location - About 1 hr to fix
          client/includes/DataAccess/Scribunto/WikibaseEntityLibrary.php on lines 114..130

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status