Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
client/includes/Hooks/EchoNotificationsHandlers.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method doWikibaseHandleChange has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function doWikibaseHandleChange( Change $change ) {
        if ( $this->sendEchoNotification !== true ) {
            return false;
        }
Severity: Minor
Found in client/includes/Hooks/EchoNotificationsHandlers.php - About 1 hr to fix

    Function getTitleForNotification has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getTitleForNotification( DiffOp $siteLinkDiffOp ) {
        if ( $siteLinkDiffOp instanceof DiffOpAdd ) {
            $new = $siteLinkDiffOp->getNewValue();
            $newTitle = Title::newFromText( $new );
            return $this->canNotifyForTitle( $newTitle ) ? $newTitle : false;
    Severity: Minor
    Found in client/includes/Hooks/EchoNotificationsHandlers.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            RepoLinker $repoLinker,
        NamespaceChecker $namespaceChecker,
        RedirectLookup $redirectLookup,
        UserOptionsManager $userOptionsManager,
        $siteId,
    Severity: Major
    Found in client/includes/Hooks/EchoNotificationsHandlers.php - About 50 mins to fix

      Avoid too many return statements within this method.
      Open

                  return $newTitle;
      Severity: Major
      Found in client/includes/Hooks/EchoNotificationsHandlers.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return true;
        Severity: Major
        Found in client/includes/Hooks/EchoNotificationsHandlers.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return false;
          Severity: Major
          Found in client/includes/Hooks/EchoNotificationsHandlers.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return false;
            Severity: Major
            Found in client/includes/Hooks/EchoNotificationsHandlers.php - About 30 mins to fix

              Function doWikibaseHandleChange has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function doWikibaseHandleChange( Change $change ) {
        if ( $this->sendEchoNotification !== true ) {
            return false;
        }
              Severity: Minor
              Found in client/includes/Hooks/EchoNotificationsHandlers.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status