Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
client/includes/Hooks/UpdateRepoHookHandler.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

        NamespaceChecker $namespaceChecker,
        JobQueueGroupFactory $jobQueueGroupFactory,
        DatabaseEntitySource $entitySource,
        SiteLinkLookup $siteLinkLookup,
        LoggerInterface $logger,
Severity: Major
Found in client/includes/Hooks/UpdateRepoHookHandler.php - About 1 hr to fix

    Method onArticleDeleteComplete has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $wikiPage,
        $user,
        $reason,
        $id,
        $content,
    Severity: Major
    Found in client/includes/Hooks/UpdateRepoHookHandler.php - About 50 mins to fix

      Method onPageMoveComplete has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              $oldLinkTarget,
        $newLinkTarget,
        $userIdentity,
        $pageId,
        $redirid,
      Severity: Major
      Found in client/includes/Hooks/UpdateRepoHookHandler.php - About 50 mins to fix

        Method factory has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                JobQueueGroupFactory $jobQueueGroupFactory,
        ClientDomainDbFactory $clientDomainDbFactory,
        DatabaseEntitySource $entitySource,
        NamespaceChecker $namespaceChecker,
        SettingsArray $clientSettings,
        Severity: Minor
        Found in client/includes/Hooks/UpdateRepoHookHandler.php - About 45 mins to fix

          Function onPageMoveComplete has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function onPageMoveComplete(
        $oldLinkTarget,
        $newLinkTarget,
        $userIdentity,
        $pageId,
          Severity: Minor
          Found in client/includes/Hooks/UpdateRepoHookHandler.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function __construct(
        NamespaceChecker $namespaceChecker,
        JobQueueGroupFactory $jobQueueGroupFactory,
        DatabaseEntitySource $entitySource,
        SiteLinkLookup $siteLinkLookup,
          Severity: Major
          Found in client/includes/Hooks/UpdateRepoHookHandler.php and 1 other location - About 2 hrs to fix
          repo/includes/Store/PropertyTermsRebuilder.php on lines 45..63

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 126.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status