Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
client/includes/Serializer/ClientEntitySerializer.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function filterEntitySerializationUsingLangCodes has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    private function filterEntitySerializationUsingLangCodes( array $serialization ) {
        if ( $this->filterLangCodes ) {
            if ( array_key_exists( 'labels', $serialization ) ) {
                foreach ( $serialization['labels'] as $langCode => $languageArray ) {
                    if ( !in_array( $langCode, $this->filterLangCodes ) ) {
Severity: Minor
Found in client/includes/Serializer/ClientEntitySerializer.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getTermsSerializationWithFallbackInfo has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private function getTermsSerializationWithFallbackInfo( array $serialization ) {
        $newSerialization = $serialization;
        foreach ( $this->termFallbackChains as $requestedLanguageCode => $fallbackChain ) {
            if ( !array_key_exists( $requestedLanguageCode, $serialization ) ) {
                $fallbackSerialization = $fallbackChain->extractPreferredValue( $serialization );
Severity: Minor
Found in client/includes/Serializer/ClientEntitySerializer.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        Serializer $entitySerializer,
        PropertyDataTypeLookup $dataTypeLookup,
        EntityIdParser $entityIdParser,
        array $filterLangCodes,
        array $termFallbackChains
Severity: Minor
Found in client/includes/Serializer/ClientEntitySerializer.php - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status