Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
client/includes/Usage/Sql/SqlUsageTracker.php

Summary

Maintainability
A
1 hr
Test Coverage

Function handleDisabledUsages has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    private function handleDisabledUsages( array $usages ): array {
        $newUsages = [];

        foreach ( $usages as $usage ) {
            if ( !( $usage instanceof EntityUsage ) ) {
Severity: Minor
Found in client/includes/Usage/Sql/SqlUsageTracker.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        EntityIdParser $idParser,
        SessionConsistentConnectionManager $connectionManager,
        array $disabledUsageAspects,
        int $entityUsagePerPageLimit,
        int $addEntityUsagesBatchSize = 500
Severity: Minor
Found in client/includes/Usage/Sql/SqlUsageTracker.php - About 35 mins to fix

    Function compareAndReturnNewUsagesAccountingForDeduplication has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function compareAndReturnNewUsagesAccountingForDeduplication(
        array $newUsages,
        array $oldUsages
    ): array {
        $result = [];
    Severity: Minor
    Found in client/includes/Usage/Sql/SqlUsageTracker.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status