Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
client/resources/jquery.wikibase/jquery.wikibase.linkitem.js

Summary

Maintainability
C
1 day
Test Coverage

File jquery.wikibase.linkitem.js has 396 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @license GPL-2.0-or-later
 * @author Marius Hoch < hoo@online.de >
 */
( function ( wb ) {
Severity: Minor
Found in client/resources/jquery.wikibase/jquery.wikibase.linkitem.js - About 5 hrs to fix

    Function _onSiteSelectorChangeHandler has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _onSiteSelectorChangeHandler: function () {
            var apiUrl,
                $page = $( '#wbclient-linkItem-page' );

            $page.val( '' );
    Severity: Minor
    Found in client/resources/jquery.wikibase/jquery.wikibase.linkitem.js - About 1 hr to fix

      Function _create has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              _create: function () {
            var self = this,
                $dialogSpinner = $.createSpinner();

            this.element
      Severity: Minor
      Found in client/resources/jquery.wikibase/jquery.wikibase.linkitem.js - About 1 hr to fix

        Function _onConfirmationDataLoad has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                _onConfirmationDataLoad: function ( entity ) {
            var i, itemLink;

            if ( entity && entity.sitelinks ) {
                var siteLinkCount = 0;
        Severity: Minor
        Found in client/resources/jquery.wikibase/jquery.wikibase.linkitem.js - About 1 hr to fix

          Function _onSuccess has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  _onSuccess: function () {
            var mwApi = new mw.Api(),
                itemUri = this._linkRepoTitle(
                    'Special:ItemByTitle/' + this.options.globalSiteId + '/' + this.options.pageTitle
                );
          Severity: Minor
          Found in client/resources/jquery.wikibase/jquery.wikibase.linkitem.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                this._pageConnector.linkPages()
                    .done( this._onSuccess.bind( this ) )
                    .fail( this._onError.bind( this ) );
            Severity: Minor
            Found in client/resources/jquery.wikibase/jquery.wikibase.linkitem.js and 1 other location - About 55 mins to fix
            client/resources/jquery.wikibase/jquery.wikibase.linkitem.js on lines 460..462

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            this._pageConnector.linkPages()
                .done( this._onSuccess.bind( this ) )
                .fail( this._onError.bind( this ) );
            Severity: Minor
            Found in client/resources/jquery.wikibase/jquery.wikibase.linkitem.js and 1 other location - About 55 mins to fix
            client/resources/jquery.wikibase/jquery.wikibase.linkitem.js on lines 451..453

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status