Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star

Showing 2,096 of 2,096 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function __construct( Title $title, array $params = [] ) {
        parent::__construct( 'DispatchChangeDeletionNotification', $title, $params );

        Assert::parameter( isset( $params['pageId'] ), '$params', '$params[\'pageId\'] not set.' );
        Assert::parameter( isset( $params['archivedRevisionCount'] ), '$params', '$params[\'archivedRevisionCount\'] not set.' );
Severity: Major
Found in repo/includes/ChangeModification/DispatchChangeDeletionNotificationJob.php and 1 other location - About 3 hrs to fix
repo/includes/ChangeModification/DispatchChangeVisibilityNotificationJob.php on lines 40..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function validateModifiedStatements has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public function validateModifiedStatements(
        array $originalSerialization,
        StatementList $originalStatements,
        array $serialization,
        string $basePath = ''
Severity: Minor
Found in repo/rest-api/src/Application/Validation/StatementsValidator.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php declare( strict_types=1 );

namespace Wikibase\Repo\RestApi\Application\Serialization;

use Wikibase\DataModel\Term\Term;
Severity: Major
Found in repo/rest-api/src/Application/Serialization/LabelsDeserializer.php and 1 other location - About 3 hrs to fix
repo/rest-api/src/Application/Serialization/DescriptionsDeserializer.php on lines 1..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 143.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php declare( strict_types=1 );

namespace Wikibase\Repo\RestApi\Application\Serialization;

use Wikibase\DataModel\Term\Term;
Severity: Major
Found in repo/rest-api/src/Application/Serialization/DescriptionsDeserializer.php and 1 other location - About 3 hrs to fix
repo/rest-api/src/Application/Serialization/LabelsDeserializer.php on lines 1..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 143.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

<?php declare( strict_types=1 );

namespace Wikibase\Repo\RestApi\Application\UseCases\PatchItemStatement;

use Wikibase\Repo\RestApi\Application\UseCases\AssertItemExists;
Severity: Major
Found in repo/rest-api/src/Application/UseCases/PatchItemStatement/PatchItemStatement.php and 5 other locations - About 3 hrs to fix
repo/rest-api/src/Application/UseCases/GetItemStatement/GetItemStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/GetPropertyStatement/GetPropertyStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/PatchPropertyStatement/PatchPropertyStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/ReplaceItemStatement/ReplaceItemStatement.php on lines 1..41
repo/rest-api/src/Application/UseCases/ReplacePropertyStatement/ReplacePropertyStatement.php on lines 1..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 142.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

            new MiddlewareHandler( [
                WbRestApi::getUnexpectedErrorHandlerMiddleware(),
                new UserAgentCheckMiddleware(),
                new AuthenticationMiddleware( MediaWikiServices::getInstance()->getUserIdentityUtils() ),
                new BotRightCheckMiddleware( MediaWikiServices::getInstance()->getPermissionManager(), $responseFactory ),
Severity: Major
Found in repo/rest-api/src/RouteHandlers/ReplaceStatementRouteHandler.php and 2 other locations - About 3 hrs to fix
repo/rest-api/src/RouteHandlers/PatchStatementRouteHandler.php on lines 64..78
repo/rest-api/src/RouteHandlers/RemoveStatementRouteHandler.php on lines 61..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 142.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

            new MiddlewareHandler( [
                WbRestApi::getUnexpectedErrorHandlerMiddleware(),
                new UserAgentCheckMiddleware(),
                new AuthenticationMiddleware( MediaWikiServices::getInstance()->getUserIdentityUtils() ),
                new BotRightCheckMiddleware( MediaWikiServices::getInstance()->getPermissionManager(), $responseFactory ),
Severity: Major
Found in repo/rest-api/src/RouteHandlers/PatchStatementRouteHandler.php and 2 other locations - About 3 hrs to fix
repo/rest-api/src/RouteHandlers/RemoveStatementRouteHandler.php on lines 61..75
repo/rest-api/src/RouteHandlers/ReplaceStatementRouteHandler.php on lines 63..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 142.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

<?php declare( strict_types=1 );

namespace Wikibase\Repo\RestApi\Application\UseCases\GetItemStatement;

use Wikibase\Repo\RestApi\Application\UseCases\AssertItemExists;
Severity: Major
Found in repo/rest-api/src/Application/UseCases/GetItemStatement/GetItemStatement.php and 5 other locations - About 3 hrs to fix
repo/rest-api/src/Application/UseCases/GetPropertyStatement/GetPropertyStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/PatchItemStatement/PatchItemStatement.php on lines 1..42
repo/rest-api/src/Application/UseCases/PatchPropertyStatement/PatchPropertyStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/ReplaceItemStatement/ReplaceItemStatement.php on lines 1..41
repo/rest-api/src/Application/UseCases/ReplacePropertyStatement/ReplacePropertyStatement.php on lines 1..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 142.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

<?php declare( strict_types=1 );

namespace Wikibase\Repo\RestApi\Application\UseCases\ReplaceItemStatement;

use Wikibase\Repo\RestApi\Application\UseCases\AssertItemExists;
Severity: Major
Found in repo/rest-api/src/Application/UseCases/ReplaceItemStatement/ReplaceItemStatement.php and 5 other locations - About 3 hrs to fix
repo/rest-api/src/Application/UseCases/GetItemStatement/GetItemStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/GetPropertyStatement/GetPropertyStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/PatchItemStatement/PatchItemStatement.php on lines 1..42
repo/rest-api/src/Application/UseCases/PatchPropertyStatement/PatchPropertyStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/ReplacePropertyStatement/ReplacePropertyStatement.php on lines 1..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 142.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

            new MiddlewareHandler( [
                WbRestApi::getUnexpectedErrorHandlerMiddleware(),
                new UserAgentCheckMiddleware(),
                new AuthenticationMiddleware( MediaWikiServices::getInstance()->getUserIdentityUtils() ),
                new BotRightCheckMiddleware( MediaWikiServices::getInstance()->getPermissionManager(), $responseFactory ),
Severity: Major
Found in repo/rest-api/src/RouteHandlers/RemoveStatementRouteHandler.php and 2 other locations - About 3 hrs to fix
repo/rest-api/src/RouteHandlers/PatchStatementRouteHandler.php on lines 64..78
repo/rest-api/src/RouteHandlers/ReplaceStatementRouteHandler.php on lines 63..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 142.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

<?php declare( strict_types=1 );

namespace Wikibase\Repo\RestApi\Application\UseCases\GetPropertyStatement;

use Wikibase\Repo\RestApi\Application\UseCases\AssertPropertyExists;
Severity: Major
Found in repo/rest-api/src/Application/UseCases/GetPropertyStatement/GetPropertyStatement.php and 5 other locations - About 3 hrs to fix
repo/rest-api/src/Application/UseCases/GetItemStatement/GetItemStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/PatchItemStatement/PatchItemStatement.php on lines 1..42
repo/rest-api/src/Application/UseCases/PatchPropertyStatement/PatchPropertyStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/ReplaceItemStatement/ReplaceItemStatement.php on lines 1..41
repo/rest-api/src/Application/UseCases/ReplacePropertyStatement/ReplacePropertyStatement.php on lines 1..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 142.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

<?php declare( strict_types=1 );

namespace Wikibase\Repo\RestApi\Application\UseCases\PatchPropertyStatement;

use Wikibase\Repo\RestApi\Application\UseCases\AssertPropertyExists;
Severity: Major
Found in repo/rest-api/src/Application/UseCases/PatchPropertyStatement/PatchPropertyStatement.php and 5 other locations - About 3 hrs to fix
repo/rest-api/src/Application/UseCases/GetItemStatement/GetItemStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/GetPropertyStatement/GetPropertyStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/PatchItemStatement/PatchItemStatement.php on lines 1..42
repo/rest-api/src/Application/UseCases/ReplaceItemStatement/ReplaceItemStatement.php on lines 1..41
repo/rest-api/src/Application/UseCases/ReplacePropertyStatement/ReplacePropertyStatement.php on lines 1..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 142.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

<?php declare( strict_types=1 );

namespace Wikibase\Repo\RestApi\Application\UseCases\ReplacePropertyStatement;

use Wikibase\Repo\RestApi\Application\UseCases\AssertPropertyExists;
Severity: Major
Found in repo/rest-api/src/Application/UseCases/ReplacePropertyStatement/ReplacePropertyStatement.php and 5 other locations - About 3 hrs to fix
repo/rest-api/src/Application/UseCases/GetItemStatement/GetItemStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/GetPropertyStatement/GetPropertyStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/PatchItemStatement/PatchItemStatement.php on lines 1..42
repo/rest-api/src/Application/UseCases/PatchPropertyStatement/PatchPropertyStatement.php on lines 1..40
repo/rest-api/src/Application/UseCases/ReplaceItemStatement/ReplaceItemStatement.php on lines 1..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 142.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

EditEntity has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

class EditEntity extends ModifyEntity {

    public const PARAM_DATA = 'data';

    public const PARAM_CLEAR = 'clear';
Severity: Minor
Found in repo/includes/Api/EditEntity.php - About 3 hrs to fix

    Item has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Item implements
    StatementListProvidingEntity,
    FingerprintProvider,
    StatementListHolder,
    LabelsProvider,
    Severity: Minor
    Found in lib/packages/wikibase/data-model/src/Entity/Item.php - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php

declare( strict_types = 1 );

namespace Wikibase\Repo\ChangeOp;
      Severity: Major
      Found in repo/includes/ChangeOp/ChangeOpDescriptionResult.php and 1 other location - About 2 hrs to fix
      repo/includes/ChangeOp/ChangeOpLabelResult.php on lines 1..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 141.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php

declare( strict_types = 1 );

namespace Wikibase\Repo\ChangeOp;
      Severity: Major
      Found in repo/includes/ChangeOp/ChangeOpLabelResult.php and 1 other location - About 2 hrs to fix
      repo/includes/ChangeOp/ChangeOpDescriptionResult.php on lines 1..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 141.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function 7dd0 has 74 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      /***/ (function(module, exports, __webpack_require__) {

"use strict";

var $ = __webpack_require__("23e7");
      Severity: Major
      Found in view/lib/wikibase-tainted-ref/dist/tainted-ref.common.js - About 2 hrs to fix

        Function exports has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

        /******/ (function(modules) { // webpackBootstrap
/******/     // The module cache
/******/     var installedModules = {};
/******/
/******/     // The require function
        Severity: Minor
        Found in view/lib/wikibase-tainted-ref/dist/tainted-ref.common.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            private function buildResult( EntityId $entityId = null, Term $oldDescription = null, Term $newDescription = null ) {

        $isEntityChanged = false;
        $oldDescriptionText = $oldDescription ? $oldDescription->getText() : '';
        $newDescriptionText = $newDescription ? $newDescription->getText() : '';
        Severity: Major
        Found in repo/includes/ChangeOp/ChangeOpDescription.php and 1 other location - About 2 hrs to fix
        repo/includes/ChangeOp/ChangeOpLabel.php on lines 82..95

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 140.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language