Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star

Showing 2,096 of 2,096 total issues

Function saveBridge has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public async saveBridge(): Promise<unknown> {
        if ( this.state.applicationStatus !== ApplicationStatus.READY ) {
            this.commit( 'addApplicationErrors', [ {
                type: ErrorTypes.APPLICATION_LOGIC_ERROR,
                info: { stack: ( new Error() ).stack },
Severity: Major
Found in client/data-bridge/src/store/actions.ts - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php declare( strict_types=1 );

namespace Wikibase\Repo\RestApi\Application\UseCases;

use Wikibase\DataModel\Statement\StatementGuid;
    Severity: Major
    Found in repo/rest-api/src/Application/UseCases/GetLatestStatementSubjectRevisionMetadata.php and 1 other location - About 2 hrs to fix
    repo/rest-api/src/Application/UseCases/GetLatestItemRevisionMetadata.php on lines 1..39

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 128.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php declare( strict_types=1 );

namespace Wikibase\Repo\RestApi\Application\UseCases;

use Wikibase\DataModel\Entity\ItemId;
    Severity: Major
    Found in repo/rest-api/src/Application/UseCases/GetLatestItemRevisionMetadata.php and 1 other location - About 2 hrs to fix
    repo/rest-api/src/Application/UseCases/GetLatestStatementSubjectRevisionMetadata.php on lines 1..39

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 128.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File DatabaseTermInLangIdsAcquirer.php has 264 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Wikibase\Lib\Store\Sql\Terms;

use MediaWiki\MediaWikiServices;
    Severity: Minor
    Found in lib/includes/Store/Sql/Terms/DatabaseTermInLangIdsAcquirer.php - About 2 hrs to fix

      ChangeLineFormatter has 22 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class ChangeLineFormatter {

    /**
     * @var RepoLinker
     */
      Severity: Minor
      Found in client/includes/RecentChanges/ChangeLineFormatter.php - About 2 hrs to fix

        Property has 22 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Property implements
    StatementListProvidingEntity,
    FingerprintProvider,
    StatementListHolder,
    LabelsProvider,
        Severity: Minor
        Found in lib/packages/wikibase/data-model/src/Entity/Property.php - About 2 hrs to fix

          Function _initMenu has 58 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  _initMenu: function ( ooMenu ) {
            var self = this;
            $.ui.suggester.prototype._initMenu.apply( this, arguments );

            $( this.options.menu )
          Severity: Major
          Found in view/resources/jquery/wikibase/jquery.wikibase.entityselector.js - About 2 hrs to fix

            Method getForm has 58 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function getForm( EntityDocument $entity = null ) {
        if ( $this->languageCode === null ) {
            $this->languageCode = $this->getLanguage()->getCode();
        }
            Severity: Major
            Found in repo/includes/Specials/SpecialModifyTerm.php - About 2 hrs to fix

              Method onResourceLoaderRegisterModules has 58 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function onResourceLoaderRegisterModules( ResourceLoader $resourceLoader ) {
        $moduleTemplate = [
            'localBasePath' => __DIR__ . '/..',
            'remoteExtPath' => 'Wikibase/repo',
        ];
              Severity: Major
              Found in repo/includes/RepoHooks.php - About 2 hrs to fix

                File SubmitEntityAction.php has 263 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php

declare( strict_types = 1 );

namespace Wikibase\Repo\Actions;
                Severity: Minor
                Found in repo/includes/Actions/SubmitEntityAction.php - About 2 hrs to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          destroy: function () {
            this._listview.destroy();
            if ( this._statementAdder ) {
                this._statementAdder.destroy();
                this._statementAdder = null;
                  Severity: Major
                  Found in view/resources/jquery/wikibase/jquery.wikibase.statementlistview.js and 1 other location - About 2 hrs to fix
                  view/resources/jquery/wikibase/jquery.wikibase.statementgrouplistview.js on lines 85..92

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 81.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          destroy: function () {
            this.listview.destroy();
            if ( this._statementGroupAdder ) {
                this._statementGroupAdder.destroy();
                this._statementGroupAdder = null;
                  Severity: Major
                  Found in view/resources/jquery/wikibase/jquery.wikibase.statementgrouplistview.js and 1 other location - About 2 hrs to fix
                  view/resources/jquery/wikibase/jquery.wikibase.statementlistview.js on lines 139..146

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 81.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function runUseCase(): Response {
        $jsonBody = $this->getValidatedBody();
        '@phan-var array $jsonBody'; // guaranteed to be an array per getBodyParamSettings()

        try {
                  Severity: Major
                  Found in repo/rest-api/src/RouteHandlers/CreatePropertyRouteHandler.php and 1 other location - About 2 hrs to fix
                  repo/rest-api/src/RouteHandlers/CreateItemRouteHandler.php on lines 90..109

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 127.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function runUseCase(): Response {
        $jsonBody = $this->getValidatedBody();
        '@phan-var array $jsonBody'; // guaranteed to be an array per getBodyParamSettings()

        try {
                  Severity: Major
                  Found in repo/rest-api/src/RouteHandlers/CreateItemRouteHandler.php and 1 other location - About 2 hrs to fix
                  repo/rest-api/src/RouteHandlers/CreatePropertyRouteHandler.php on lines 88..107

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 127.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function save has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          save: function ( newFingerprint, oldFingerprint ) {
            var labelsChanger = this._labelsChanger,
                descriptionsChanger = this._descriptionsChanger,
                aliasesChanger = this._aliasesChanger,
                changes = [],
                  Severity: Major
                  Found in view/resources/wikibase/entityChangers/EntityTermsChanger.js - About 2 hrs to fix

                    Method coalesceRuns has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private function coalesceRuns( EntityId $entityId, array $changes ) {
        $coalesced = [];

        $currentRun = [];
        $currentUser = null;
                    Severity: Major
                    Found in client/includes/Changes/ChangeRunCoalescer.php - About 2 hrs to fix

                      Method loadEntity has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function loadEntity( array $requestParams, ?EntityId $entityId = null, $assignFreshId = self::ASSIGN_FRESH_ID ): EntityDocument {
        if ( !in_array( $assignFreshId, [ self::ASSIGN_FRESH_ID, self::NO_FRESH_ID ] ) ) {
            throw new InvalidArgumentException(
                '$assignFreshId must be either of the EntitySavingHelper::ASSIGN_FRESH_ID/NO_FRESH_ID constants.'
            );
                      Severity: Major
                      Found in repo/includes/Api/EntitySavingHelper.php - About 2 hrs to fix

                        Method execute has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function execute(): void {
        $lookup = $this->revisionLookup;

        $params = $this->extractRequestParams();
        $this->validateParameters( $params );
                        Severity: Major
                        Found in repo/includes/Api/LinkTitles.php - About 2 hrs to fix

                          Function actions has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          export default function actions( metricTracker: TrackFunction ): ActionTree<Application, Application> {
    return {
        [ STORE_INIT ](
            context: ActionContext<Application, Application>,
            guids: string[],
                          Severity: Major
                          Found in view/lib/wikibase-tainted-ref/src/store/actions.ts - About 2 hrs to fix

                            Function undo has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function undo(): void {
        $request = $this->getRequest();
        $undidRevId = $request->getInt( 'undo' );
        $undidAfterRevId = $request->getInt( 'undoafter' );
        $restoreId = $request->getInt( 'restore' );
                            Severity: Minor
                            Found in repo/includes/Actions/SubmitEntityAction.php - About 2 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language