wikimedia/mediawiki-extensions-Wikibase

Method getChangedAspects has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getChangedAspects( EntityChange $change ) {
        $aspects = [];
        $diffAspects = $change->getCompactDiff();

        if ( $diffAspects->getSiteLinkChanges() !== [] ) {

Method generateOpHtml has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function generateOpHtml( array $path, DiffOp $op ) {
        if ( $op->isAtomic() ) {
            $localizedPath = $path;

            $html = $this->generateDiffHeaderHtml( implode( ' / ', $localizedPath ) );

Method generateNewId has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function generateNewId( IDatabase $database, $type, $retry = true ) {
        $database->startAtomic( __METHOD__ );

        $currentId = $database->newSelectQueryBuilder()
            ->select( 'id_value' )

Method getAllowedParams has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function getAllowedParams(): array {
        return array_merge(
            [
                'claim' => [
                    ParamValidator::PARAM_TYPE => 'string',

Method validateTermSerialization has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function validateTermSerialization( $serialization, $languageCode ) {
        $this->assertArray(
            $serialization,
            'An array was expected, but not found in term serialization for the language code ' . $languageCode
        );

Method processUnit has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function processUnit( $unit ) {
        $this->output( "Processing $unit...\n" );
        $query = <<<QUERY
SELECT * WHERE {
{

Method validateAndDeserialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function validateAndDeserialize( UseCaseRequest $request ): DeserializedRequestAdapter {
        $requestObjectId = spl_object_id( $request );
        if ( array_key_exists( $requestObjectId, $this->validRequestResults ) ) {
            return $this->validRequestResults[$requestObjectId];
        }

Method execute has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function execute( ReplaceStatementRequest $request ): ReplaceStatementResponse {
        $deserializedRequest = $this->validator->validateAndDeserialize( $request );
        $statementId = $deserializedRequest->getStatementId();
        $statement = $deserializedRequest->getStatement();
        $editMetadata = $deserializedRequest->getEditMetadata();

Method __construct has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function __construct( array $fields = [] ) {
        Assert::parameter(
            !array_diff( array_keys( $fields ), self::FIELD_NAMES ),
            '$fields',
            'must only contain the following keys: termType, termLanguage, termText'

Method newFromEntityDiff has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function newFromEntityDiff( Diff $entityDiff ) {
        $labelChanges = [];
        $descriptionChanges = [];
        $statementChanges = [];
        $siteLinkChanges = [];

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    private function getLuaFunctionCallTracker(): LuaFunctionCallTracker {
        if ( !$this->luaFunctionCallTracker ) {
            $mwServices = MediaWikiServices::getInstance();
            $settings = WikibaseClient::getSettings( $mwServices );

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    private function getLuaFunctionCallTracker(): LuaFunctionCallTracker {
        if ( !$this->luaFunctionCallTracker ) {
            $mwServices = MediaWikiServices::getInstance();
            $settings = WikibaseClient::getSettings( $mwServices );

• Read up
  Read up

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.

Open

        Article $article,
        IContextSource $context,
        PermissionManager $permissionManager,
        RevisionLookup $revisionLookup,
        TempUserCreator $tempUserCreator,

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.

Open

        array $tags,
        SpecialPageCopyrightView $specialPageCopyrightView,
        EntityNamespaceLookup $entityNamespaceLookup,
        SummaryFormatter $summaryFormatter,
        EntityTitleLookup $entityTitleLookup,

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.

Open

        ApiMain $mainModule,
        string $moduleName,
        DeserializerFactory $deserializerFactory,
        ApiErrorReporter $errorReporter,
        StatementChangeOpFactory $statementChangeOpFactory,

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.

Open

        array $tags,
        SpecialPageCopyrightView $copyrightView,
        SummaryFormatter $summaryFormatter,
        EntityTitleLookup $entityTitleLookup,
        MediaWikiEditEntityFactory $editEntityFactory,

Method factory has 12 arguments (exceeds 4 allowed). Consider refactoring.

Open

        ApiMain $apiMain,
        string $moduleName,
        SiteLookup $siteLookup,
        IBufferingStatsdDataFactory $stats,
        ApiHelperFactory $apiHelperFactory,

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.

Open

        ApiMain $mainModule,
        string $moduleName,
        ApiErrorReporter $errorReporter,
        Deserializer $statementDeserializer,
        StatementChangeOpFactory $statementChangeOpFactory,

Method factory has 12 arguments (exceeds 4 allowed). Consider refactoring.

Open

        InterwikiLookup $interwikiLookup,
        SpecialPageFactory $specialPageFactory,
        EntityExistenceChecker $entityExistenceChecker,
        EntityIdParser $entityIdParser,
        EntityLinkFormatterFactory $entityLinkFormatterFactory,

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.

Open

        FingerprintChangeOpFactory $fingerprintChangeOpFactory,
        StatementChangeOpFactory $statementChangeOpFactory,
        SiteLinkChangeOpFactory $siteLinkChangeOpFactory,
        TermChangeOpSerializationValidator $termChangeOpSerializationValidator,
        SiteLinkBadgeChangeOpSerializationValidator $badgeChangeOpSerializationValidator,