Method `createEntityChangeOp` has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function createEntityChangeOp( array $changeRequest ) {
        $this->assertArray( $changeRequest['sitelinks'], 'List of sitelinks must be an array' );

        $siteLinksChangeOps = new ChangeOps();
        $sites = $this->siteLinkTargetProvider->getSiteList( $this->siteLinkGroups );

Found in repo/includes/ChangeOp/Deserialization/SiteLinksChangeOpDeserializer.php - About 1 hr to fix

Method `convertToFormattableSummary` has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function convertToFormattableSummary( EditSummary $editSummary ): FormatableSummary {
        switch ( true ) {
            case $editSummary instanceof PatchPropertyEditSummary:
                return $this->wholeEntityEditSummaryConverter->newSummaryForPropertyPatch( $editSummary );

Found in repo/rest-api/src/Infrastructure/EditSummaryFormatter.php - About 1 hr to fix

Method `execute` has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute() {
        if ( !ExtensionRegistry::getInstance()->isLoaded( 'WikibaseRepository' ) ) {
            $this->fatalError(
                "You need to have Wikibase enabled in order to use this "
                . "maintenance script!\n\n",

Found in repo/maintenance/rebuildItemTerms.php - About 1 hr to fix

Method `validate` has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function validate(
        ?string $itemId,
        string $siteId,
        array $sitelink,
        string $basePath = ''

Found in repo/rest-api/src/Infrastructure/SiteLinkLookupSitelinkValidator.php - About 1 hr to fix

Method `execute` has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute() {
        if ( WikibaseRepo::getSettings()
             ->getSetting( 'enablePopulateWithRandomEntitiesAndTermsScript' ) !== true
        ) {
            $this->output(

Found in repo/maintenance/populateWithRandomEntitiesAndTerms.php - About 1 hr to fix

Method `throwUseCaseError` has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function throwUseCaseError( ValidationError $validationError ): void {
        $context = $validationError->getContext();
        switch ( $validationError->getCode() ) {
            case LanguageCodeValidator::CODE_INVALID_LANGUAGE_CODE:
                throw UseCaseError::newPatchResultInvalidKey( '', $context[LanguageCodeValidator::CONTEXT_LANGUAGE_CODE] );

Found in repo/rest-api/src/Application/UseCases/PatchPropertyLabels/PatchedPropertyLabelsValidator.php - About 1 hr to fix

Method `execute` has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute( PatchPropertyDescriptionsRequest $request ): PatchPropertyDescriptionsResponse {
        $deserializedRequest = $this->useCaseValidator->validateAndDeserialize( $request );
        $propertyId = $deserializedRequest->getPropertyId();

        $this->assertPropertyExists->execute( $propertyId );

Found in repo/rest-api/src/Application/UseCases/PatchPropertyDescriptions/PatchPropertyDescriptions.php - About 1 hr to fix

Method `format` has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function format( $value ) {
        if ( !( $value instanceof TimeValue ) ) {
            throw new InvalidArgumentException( 'Data value type mismatch. Expected a TimeValue.' );
        }

Found in lib/includes/Formatters/TimeDetailsFormatter.php - About 1 hr to fix

Method `toStandardUnits` has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toStandardUnits( UnboundedQuantityValue $value ) {
        $fromUnit = $value->getUnit();

        if ( $fromUnit === '1' ) {
            // Won't convert unitless values

Found in lib/includes/Units/UnitConverter.php - About 1 hr to fix

Method `saveLinksOfItem` has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function saveLinksOfItem( Item $item ): bool {
        //First check whether there's anything to update
        $newLinks = $item->getSiteLinkList()->toArray();
        $oldLinks = $this->getSiteLinksForItem( $item->getId() );

Found in lib/includes/Store/Sql/SiteLinkTable.php - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    'WikibaseClient.TermFallbackCacheFactory' => function ( MediaWikiServices $services ): TermFallbackCacheFactory {
        $settings = WikibaseClient::getSettings( $services );
        return new TermFallbackCacheFactory(
            $settings->getSetting( 'sharedCacheType' ),
            WikibaseClient::getLogger( $services ),

Found in client/WikibaseClient.ServiceWiring.php and 1 other location - About 1 hr to fix

Read up
Read up

repo/WikibaseRepo.ServiceWiring.php on lines 1947..1958

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.