Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star

Showing 2,096 of 2,096 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php declare( strict_types=1 );

namespace Wikibase\Repo\RestApi\Application\UseCases\PatchItemStatement;

use Wikibase\Repo\RestApi\Application\UseCaseRequestValidation\ItemStatementIdRequest;
Severity: Major
Found in repo/rest-api/src/Application/UseCases/PatchItemStatement/PatchItemStatementRequest.php and 3 other locations - About 1 hr to fix
repo/rest-api/src/Application/UseCases/PatchPropertyStatement/PatchPropertyStatementRequest.php on lines 1..32
repo/rest-api/src/Application/UseCases/ReplaceItemStatement/ReplaceItemStatementRequest.php on lines 1..31
repo/rest-api/src/Application/UseCases/ReplacePropertyStatement/ReplacePropertyStatementRequest.php on lines 1..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

        LanguageLinkBadgeDisplay $badgeDisplay,
        NamespaceChecker $namespaceChecker,
        SiteLinkLookup $siteLinkLookup,
        EntityLookup $entityLookup,
        SiteLookup $siteLookup,
Severity: Major
Found in client/includes/Hooks/LangLinkHandlerFactory.php - About 1 hr to fix

    Method factory has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            LanguageNameUtils $languageNameUtils,
        AnonymousEditWarningBuilder $anonymousEditWarningBuilder,
        ChangeOpFactoryProvider $changeOpFactoryProvider,
        MediaWikiEditEntityFactory $editEntityFactory,
        EntityPermissionChecker $entityPermissionChecker,
    Severity: Major
    Found in repo/includes/Specials/SpecialSetDescription.php - About 1 hr to fix

      Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              ApiMain $mainModule,
        string $moduleName,
        StatementChangeOpFactory $statementChangeOpFactory,
        ApiErrorReporter $errorReporter,
        StatementModificationHelper $modificationHelper,
      Severity: Major
      Found in repo/includes/Api/CreateClaim.php - About 1 hr to fix

        Method factory has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                AnonymousEditWarningBuilder $anonymousEditWarningBuilder,
        ChangeOpFactoryProvider $changeOpFactoryProvider,
        MediaWikiEditEntityFactory $editEntityFactory,
        EntityTitleLookup $entityTitleLookup,
        FallbackLabelDescriptionLookupFactory $labelDescriptionLookupFactory,
        Severity: Major
        Found in repo/includes/Specials/SpecialSetSiteLink.php - About 1 hr to fix

          Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $name,
        $restriction,
        array $tags,
        SpecialPageCopyrightView $copyrightView,
        EntityNamespaceLookup $entityNamespaceLookup,
          Severity: Major
          Found in repo/includes/Specials/SpecialNewEntity.php - About 1 hr to fix

            Method factory has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    ApiMain $mainModule,
        string $moduleName,
        ApiHelperFactory $apiHelperFactory,
        ChangeOpFactoryProvider $changeOpFactoryProvider,
        EntityIdParser $entityIdParser,
            Severity: Major
            Found in repo/includes/Api/SetQualifier.php - About 1 hr to fix

              Method factory has 9 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      ApiMain $mainModule,
        string $moduleName,
        ApiHelperFactory $apiHelperFactory,
        ChangeOpFactoryProvider $changeOpFactoryProvider,
        EntityIdParser $entityIdParser,
              Severity: Major
              Found in repo/includes/Api/RemoveClaims.php - About 1 hr to fix

                Method factory has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        ApiMain $mainModule,
        string $moduleName,
        ApiHelperFactory $apiHelperFactory,
        ChangeOpFactoryProvider $changeOpFactoryProvider,
        EntityIdParser $entityIdParser,
                Severity: Major
                Found in repo/includes/Api/SetClaimValue.php - About 1 hr to fix

                  Method factory has 9 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          ApiMain $mainModule,
        string $moduleName,
        ApiHelperFactory $apiHelperFactory,
        ChangeOpFactoryProvider $changeOpFactoryProvider,
        EntityIdParser $entityIdParser,
                  Severity: Major
                  Found in repo/includes/Api/RemoveQualifiers.php - About 1 hr to fix

                    Method factory has 9 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            LanguageNameUtils $languageNameUtils,
        AnonymousEditWarningBuilder $anonymousEditWarningBuilder,
        ChangeOpFactoryProvider $changeOpFactoryProvider,
        MediaWikiEditEntityFactory $editEntityFactory,
        EntityPermissionChecker $entityPermissionChecker,
                    Severity: Major
                    Found in repo/includes/Specials/SpecialSetLabel.php - About 1 hr to fix

                      Method factory has 9 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              LanguageNameUtils $languageNameUtils,
        AnonymousEditWarningBuilder $anonymousEditWarningBuilder,
        ChangeOpFactoryProvider $changeOpFactoryProvider,
        MediaWikiEditEntityFactory $editEntityFactory,
        EntityPermissionChecker $entityPermissionChecker,
                      Severity: Major
                      Found in repo/includes/Specials/SpecialSetAliases.php - About 1 hr to fix

                        Method factory has 9 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                ApiMain $mainModule,
        string $moduleName,
        ApiHelperFactory $apiHelperFactory,
        ChangeOpFactoryProvider $changeOpFactoryProvider,
        EntityIdParser $entityIdParser,
                        Severity: Major
                        Found in repo/includes/Api/RemoveReferences.php - About 1 hr to fix

                          Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  EntityLookup $lookup,
        EntityIdParser $idParser,
        array $urlSchemes,
        string $itemVocabularyBaseUri,
        ContentLanguages $contentLanguages,
                          Severity: Major
                          Found in repo/includes/ValidatorBuilders.php - About 1 hr to fix

                            Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    array $conceptUris,
        array $dataUris,
        EntitySourceDefinitions $entitySourceDefinitions,
        array $rdfTurtleNodePrefixes,
        array $rdfTurtlePredicatePrefixes,
                            Severity: Major
                            Found in repo/includes/Rdf/RdfVocabulary.php - About 1 hr to fix

                              Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      SeekableEntityIdPager $idPager,
        MessageReporter $progressReporter,
        MessageReporter $errorReporter,
        RepoDomainDb $db,
        EntityLookup $entityLookup,
                              Severity: Major
                              Found in repo/maintenance/EntityQuantityUnitRebuilder.php - About 1 hr to fix

                                Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                        PatchPropertyDescriptionsValidator $useCaseValidator,
        AssertPropertyExists $assertPropertyExists,
        AssertUserIsAuthorized $assertUserIsAuthorized,
        PropertyDescriptionsRetriever $descriptionsRetriever,
        DescriptionsSerializer $descriptionsSerializer,
                                Severity: Major
                                Found in repo/rest-api/src/Application/UseCases/PatchPropertyDescriptions/PatchPropertyDescriptions.php - About 1 hr to fix

                                  Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                          PatchPropertyAliasesValidator $validator,
        AssertPropertyExists $assertPropertyExists,
        AssertUserIsAuthorized $assertUserIsAuthorized,
        PropertyAliasesRetriever $aliasesRetriever,
        AliasesSerializer $aliasesSerializer,
                                  Severity: Major
                                  Found in repo/rest-api/src/Application/UseCases/PatchPropertyAliases/PatchPropertyAliases.php - About 1 hr to fix

                                    Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                            PatchSitelinksValidator $useCaseValidator,
        AssertItemExists $assertItemExists,
        AssertUserIsAuthorized $assertUserIsAuthorized,
        SitelinksRetriever $SitelinksRetriever,
        SitelinksSerializer $sitelinksSerializer,
                                    Severity: Major
                                    Found in repo/rest-api/src/Application/UseCases/PatchSitelinks/PatchSitelinks.php - About 1 hr to fix

                                      Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                              PatchPropertyValidator $validator,
        AssertPropertyExists $assertPropertyExists,
        AssertUserIsAuthorized $assertUserIsAuthorized,
        PropertyRetriever $propertyRetriever,
        PropertySerializer $propertySerializer,
                                      Severity: Major
                                      Found in repo/rest-api/src/Application/UseCases/PatchProperty/PatchProperty.php - About 1 hr to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language