wikimedia/mediawiki-extensions-Wikibase

View on GitHub

Showing 2,096 of 2,096 total issues

Method assertValidAliases has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function assertValidAliases( array $serialization ): void {
        $aliasesSerialization = $serialization[ 'aliases' ] ?? [];
        $validationError = $this->aliasesValidator->validate( $aliasesSerialization, '/aliases' );
        if ( $validationError ) {
            $errorCode = $validationError->getCode();

    Method execute has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function execute( SetItemDescriptionRequest $request ): SetItemDescriptionResponse {
            $deserializedRequest = $this->validator->validateAndDeserialize( $request );
            $itemId = $deserializedRequest->getItemId();
            $description = $deserializedRequest->getItemDescription();
            $editMetadata = $deserializedRequest->getEditMetadata();

      Method getHeadingHtml has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getHeadingHtml(
              $languageCode,
              EntityId $entityId = null,
              AliasGroupList $aliasGroups = null
          ) {
      Severity: Minor
      Found in view/src/SimpleEntityTermsView.php - About 1 hr to fix

        Method deserialize has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function deserialize( array $serialization, string $basePath = '' ): Statement {
                if ( count( $serialization ) && array_is_list( $serialization ) ) {
                    throw new InvalidFieldTypeException( $serialization, $basePath );
                }
        
        

          Method assertValidLabelsAndDescriptions has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function assertValidLabelsAndDescriptions( array $serialization, Item $originalItem ): void {
                  $labels = $serialization['labels'] ?? [];
                  $descriptions = $serialization['descriptions'] ?? [];
                  $validationError = $this->labelsSyntaxValidator->validate( $labels, '/labels' ) ??
                                     $this->descriptionsSyntaxValidator->validate( $descriptions, '/descriptions' ) ??

            Method getEntityRevisionFromCache has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getEntityRevisionFromCache(
                    EntityId $entityId,
                    $revisionId = 0,
                    $mode = LookupConstants::LATEST_FROM_REPLICA
                ) {
            Severity: Minor
            Found in lib/includes/Store/CacheRetrievingEntityRevisionLookup.php - About 1 hr to fix

              Method selectFieldValuesForPrimaryKey has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function selectFieldValuesForPrimaryKey(
                      string $table,
                      string $selectedVar,
                      string $primaryKeyVar,
                      array $primaryKeyValues,
              Severity: Minor
              Found in lib/includes/Store/Sql/Terms/DatabaseInnerTermStoreCleaner.php - About 1 hr to fix

                Method prefetchCachedTerms has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function prefetchCachedTerms( array $entityIds, array $termTypes, array $languageCodes ): array {
                        [
                            self::RESOLVED_KEYS => $cacheKeys,
                            self::UNRESOLVED_IDS => $unresolvedIds, // This is intentionally unused.
                            self::KEY_PARTS_MAP => $keyPartsMap,
                Severity: Minor
                Found in lib/includes/Store/CachingPrefetchingTermLookup.php - About 1 hr to fix

                  Method parseWellKnownProperty has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private static function parseWellKnownProperty(
                          array $wellKnownPropertyIds,
                          string $wellKnownName,
                          LoggerInterface $logger
                      ): ?NumericPropertyId {
                  Severity: Minor
                  Found in lib/includes/Formatters/Reference/WellKnownReferenceProperties.php - About 1 hr to fix

                    Function getPermissionErrors has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public async getPermissionErrors( title: string ): Promise<PermissionError[]> {
                            const response = await this.api.get( {
                                action: 'query',
                                titles: new Set( [ title ] ),
                                prop: new Set( [ 'info' ] ),

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                          protected function generateDiffHeaderHtml( string $name ): string {
                              $html = Html::openElement( 'tr' );
                              $html .= Html::element( 'td', [ 'colspan' => '2', 'class' => 'diff-lineno' ], $name );
                              // @phan-suppress-next-line PhanPluginDuplicateAdjacentStatement
                              $html .= Html::element( 'td', [ 'colspan' => '2', 'class' => 'diff-lineno' ], $name );
                      Severity: Major
                      Found in repo/includes/Diff/BasicDiffView.php and 1 other location - About 1 hr to fix
                      repo/includes/Diff/SiteLinkDiffView.php on lines 255..263

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 101.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                          protected function generateDiffHeaderHtml( string $name ): string {
                              $html = Html::openElement( 'tr' );
                              $html .= Html::element( 'td', [ 'colspan' => '2', 'class' => 'diff-lineno' ], $name );
                              // @phan-suppress-next-line PhanPluginDuplicateAdjacentStatement
                              $html .= Html::element( 'td', [ 'colspan' => '2', 'class' => 'diff-lineno' ], $name );
                      Severity: Major
                      Found in repo/includes/Diff/SiteLinkDiffView.php and 1 other location - About 1 hr to fix
                      repo/includes/Diff/BasicDiffView.php on lines 148..156

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 101.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      <?php declare( strict_types=1 );
                      
                      namespace Wikibase\Repo\RestApi\Domain\Model;
                      
                      /**
                      repo/rest-api/src/Domain/Model/CreateItemEditSummary.php on lines 1..30

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 101.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          protected function getTermsOfType( EntityId $entityId, $termType, array $languageCodes ) {
                              $this->prefetchTerms( [ $entityId ], [ $termType ], $languageCodes );
                      
                              $ret = [];
                              foreach ( $languageCodes as $languageCode ) {
                      repo/includes/FederatedProperties/ApiPrefetchingTermLookup.php on lines 54..65

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 101.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public function runUseCase( string $propertyId, string $languageCode ): Response {
                              try {
                                  $response = $this->useCase->execute( new GetPropertyLabelWithFallbackRequest( $propertyId, $languageCode ) );
                      
                                  return $response->getLabel()->getLanguageCode() === $languageCode ?
                      repo/rest-api/src/RouteHandlers/GetPropertyDescriptionWithFallbackRouteHandler.php on lines 69..79

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 101.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      <?php declare( strict_types=1 );
                      
                      namespace Wikibase\Repo\RestApi\Domain\Model;
                      
                      /**
                      Severity: Major
                      Found in repo/rest-api/src/Domain/Model/CreateItemEditSummary.php and 1 other location - About 1 hr to fix
                      repo/rest-api/src/Domain/Model/CreatePropertyEditSummary.php on lines 1..30

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 101.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public function runUseCase( string $propertyId, string $languageCode ): Response {
                              try {
                                  $response = $this->useCase->execute( new GetPropertyDescriptionWithFallbackRequest( $propertyId, $languageCode ) );
                      
                                  return $response->getDescription()->getLanguageCode() === $languageCode
                      repo/rest-api/src/RouteHandlers/GetPropertyLabelWithFallbackRouteHandler.php on lines 67..77

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 101.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          protected function getTermsOfType( EntityId $entityId, $termType, array $languageCodes ): array {
                              $this->prefetchTerms( [ $entityId ], [ $termType ], $languageCodes );
                      
                              $result = [];
                              foreach ( $languageCodes as $languageCode ) {
                      lib/includes/Store/Sql/Terms/PrefetchingEntityTermLookupBase.php on lines 143..154

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 101.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function SELF has 8 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              expertStore,
                              formatterFactory,
                              parserStore,
                              language,
                              messageProvider,
                      Severity: Major
                      Found in view/resources/wikibase/wikibase.ValueViewBuilder.js - About 1 hr to fix

                        Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                AffectedPagesFinder $affectedPagesFinder,
                                TitleFactory $titleFactory,
                                PageStore $pageStore,
                                PageUpdater $updater,
                                ChangeRunCoalescer $changeRunCoalescer,
                        Severity: Major
                        Found in client/includes/Changes/ChangeHandler.php - About 1 hr to fix
                          Severity
                          Category
                          Status
                          Source
                          Language