Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star

Showing 2,096 of 2,096 total issues

Method saveRedirect has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        EntityRedirect $redirect,
        $summary,
        User $user,
        $flags = 0,
        $baseRevId = false,
Severity: Minor
Found in lib/includes/Store/TypeDispatchingEntityStore.php - About 45 mins to fix

    Method saveRedirect has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function saveRedirect( EntityRedirect $redirect, $summary, User $user, $flags = 0, $baseRevId = false, array $tags = [] );
    Severity: Minor
    Found in lib/includes/Store/EntityStore.php - About 45 mins to fix

      Function criteriaToQueryResults has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function criteriaToQueryResults(
        IReadableDatabase $dbr,
        array $criteria,
        $termType = null,
        $entityType = null,
      Severity: Minor
      Found in lib/includes/Store/Sql/Terms/DatabaseMatchingTermsLookup.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              Term $matchedTerm,
        string $matchedTermType,
        ?EntityId $entityId,
        Term $displayLabel = null,
        Term $displayDescription = null,
      Severity: Minor
      Found in lib/includes/Interactors/TermSearchResult.php - About 45 mins to fix

        Function formatReferenceLink has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function formatReferenceLink( array $referenceUrlSnaks, array $titleSnaks ): ?string {
        if ( count( $referenceUrlSnaks ) === 1 && count( $titleSnaks ) === 1 ) {
            $referenceUrlSnak = $referenceUrlSnaks[0];
            $titleSnak = $titleSnaks[0];
            if ( $referenceUrlSnak instanceof PropertyValueSnak && $titleSnak instanceof PropertyValueSnak ) {
        Severity: Minor
        Found in lib/includes/Formatters/Reference/DataBridgeReferenceFormatter.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function buildFromBabel has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function buildFromBabel( array $babel ) {
        $chain = [];
        $fetched = [];

        // validate all the language codes and discard invalid ones
        Severity: Minor
        Found in lib/includes/LanguageFallbackChainFactory.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                EntityId $fromId,
        PropertyId $propertyId,
        array $toIds,
        $maxDepth,
        $message = null,
        Severity: Minor
        Found in lib/packages/wikibase/data-model-services/src/Lookup/MaxReferenceDepthExhaustedException.php - About 45 mins to fix

          Function validateBridgeApplicability has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public validateBridgeApplicability(
        path: MainSnakPath,
    ): Promise<unknown> {
        if ( this.state.applicationStatus === ApplicationStatus.SAVED ) {
            // saving edits can transition us from applicable to inapplicable states, but that should not be an error
          Severity: Minor
          Found in client/data-bridge/src/store/actions.ts - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  EntityId $fromId,
        PropertyId $propertyId,
        array $toIds,
        $maxEntityVisits,
        $message = null,
          Severity: Minor
          Found in lib/packages/wikibase/data-model-services/src/Lookup/MaxReferencedEntityVisitsExhaustedException.php - About 45 mins to fix

            Function newDefinitionsFromConfigArray has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function newDefinitionsFromConfigArray( array $sourceConfig, SubEntityTypesMapper $subEntityTypesMapper ) {
        $this->assertConfigArrayWellFormed( $sourceConfig );

        $sources = [];
            Severity: Minor
            Found in data-access/src/EntitySourceDefinitionsConfigParser.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getEntitySourceById has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getEntitySourceById( EntityId $id ): EntitySource {
        foreach ( $this->entitySourceDefinitions->getSources() as $source ) {
            if (
                strpos( $id->getSerialization(), $source->getConceptBaseUri() ) === 0 &&
                $source->getType() === ApiEntitySource::TYPE
            Severity: Minor
            Found in data-access/src/EntitySourceLookup.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function patchAliasGroup has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                private function patchAliasGroup( AliasGroupList $groups, $lang, DiffOp $diffOp ) {
        $hasLang = $groups->hasGroupForLanguage( $lang );

        switch ( true ) {
            case $diffOp instanceof DiffOpAdd:
            Severity: Minor
            Found in lib/packages/wikibase/data-model-services/src/Diff/Internal/AliasGroupListPatcher.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    $name,
        array $entityTypes,
        $conceptBaseUri,
        $rdfNodeNamespacePrefix,
        $rdfPredicateNamespacePrefix,
            Severity: Minor
            Found in data-access/src/ApiEntitySource.php - About 45 mins to fix

              Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      EntityIdParser $propertyIdParser,
        Deserializer $dataValueDeserializer,
        PropertyDataTypeLookup $dataTypeLookup,
        array $deserializerBuilders,
        array $dataTypeToValueTypeMap,
              Severity: Minor
              Found in lib/packages/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php - About 45 mins to fix

                Function getApiQueryResponsePage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                export function getApiQueryResponsePage( response: ApiQueryResponseBody, title: string ): ApiQueryResponsePage|null {
    for ( const normalized of ( response.normalized || [] ) ) {
        if ( normalized.from === title ) {
            title = normalized.to;
            break;
                Severity: Minor
                Found in client/data-bridge/src/data-access/ApiQuery.ts - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function addReference has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function addReference( Reference $reference, $index = null ) {
        if ( $index !== null && ( !is_int( $index ) || $index < 0 ) ) {
            throw new InvalidArgumentException( '$index must be a non-negative integer or null' );
        }
                Severity: Minor
                Found in lib/packages/wikibase/data-model/src/ReferenceList.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if ( valueChangeResult.getTempUserWatcher().getRedirectUrl() ) {
                window.location.href = valueChangeResult.getTempUserWatcher().getRedirectUrl();
            }
                Severity: Minor
                Found in view/resources/wikibase/view/ToolbarViewController.js and 1 other location - About 45 mins to fix
                view/resources/wikibase/view/ToolbarViewController.js on lines 192..194

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if ( valueChangeResult.getTempUserWatcher().getRedirectUrl() ) {
                window.location.href = valueChangeResult.getTempUserWatcher().getRedirectUrl();
            }
                Severity: Minor
                Found in view/resources/wikibase/view/ToolbarViewController.js and 1 other location - About 45 mins to fix
                view/resources/wikibase/view/ToolbarViewController.js on lines 156..158

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export function assertIsRestrictionsBody(
    body: ApiQueryResponseBody,
): asserts body is ApiQueryRestrictionsResponseBody {
    if ( !( 'restrictions' in body ) ) {
        throw new TechnicalProblem( 'API siteinfo did not return restrictions.' );
                Severity: Minor
                Found in client/data-bridge/src/data-access/ApiQuery.ts and 1 other location - About 45 mins to fix
                client/data-bridge/src/data-access/ApiQuery.ts on lines 24..30

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export function assertIsInfoTestPage(
    page: ApiQueryResponsePage,
): asserts page is ApiQueryInfoTestResponsePage {
    if ( !( 'actions' in page ) ) {
        throw new TechnicalProblem( 'API info did not return test actions.' );
                Severity: Minor
                Found in client/data-bridge/src/data-access/ApiQuery.ts and 1 other location - About 45 mins to fix
                client/data-bridge/src/data-access/ApiQuery.ts on lines 32..38

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language