Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
lib/includes/Formatters/Reference/WellKnownReferenceProperties.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method newFromArray has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function newFromArray( array $wellKnownPropertyIds, ?LoggerInterface $logger = null ): self {
        $logger = $logger ?: new NullLogger();

        $referenceUrlPropertyId = self::parseWellKnownProperty( $wellKnownPropertyIds, 'referenceUrl', $logger );
        $titlePropertyId = self::parseWellKnownProperty( $wellKnownPropertyIds, 'title', $logger );
Severity: Minor
Found in lib/includes/Formatters/Reference/WellKnownReferenceProperties.php - About 1 hr to fix

    Method parseWellKnownProperty has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static function parseWellKnownProperty(
        array $wellKnownPropertyIds,
        string $wellKnownName,
        LoggerInterface $logger
    ): ?NumericPropertyId {
    Severity: Minor
    Found in lib/includes/Formatters/Reference/WellKnownReferenceProperties.php - About 1 hr to fix

      Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              ?NumericPropertyId $referenceUrlPropertyId,
        ?NumericPropertyId $titlePropertyId,
        ?NumericPropertyId $statedInPropertyId,
        ?NumericPropertyId $authorPropertyId,
        ?NumericPropertyId $publisherPropertyId,
      Severity: Major
      Found in lib/includes/Formatters/Reference/WellKnownReferenceProperties.php - About 50 mins to fix

        Function parseWellKnownProperty has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private static function parseWellKnownProperty(
        array $wellKnownPropertyIds,
        string $wellKnownName,
        LoggerInterface $logger
    ): ?NumericPropertyId {
        Severity: Minor
        Found in lib/includes/Formatters/Reference/WellKnownReferenceProperties.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status