Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
lib/includes/Formatters/ShowCalendarModelDecider.php

Summary

Maintainability
A
1 hr
Test Coverage

Avoid too many return statements within this method.
Open

        return false;
Severity: Major
Found in lib/includes/Formatters/ShowCalendarModelDecider.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return true;
    Severity: Major
    Found in lib/includes/Formatters/ShowCalendarModelDecider.php - About 30 mins to fix

      Function calendarNameNeeded has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function calendarNameNeeded( TimeValue $value ): bool {
        // Do not care about possibly wrong calendar models with precision 10 years and more.
        if ( $value->getPrecision() <= TimeValue::PRECISION_YEAR10 ) {
            return false;
        }
      Severity: Minor
      Found in lib/includes/Formatters/ShowCalendarModelDecider.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status