Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
lib/includes/LanguageFallbackChainFactory.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method addLanguageAndVariantsToChain has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function addLanguageAndVariantsToChain( $language, array &$chain, array &$fetched ): void {
        $languageCode = is_string( $language ) ? $language : $language->getCode();

        $this->addLanguageToChain( $language, $chain, $fetched );
Severity: Minor
Found in lib/includes/LanguageFallbackChainFactory.php - About 1 hr to fix

    Method buildFromBabel has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function buildFromBabel( array $babel ) {
        $chain = [];
        $fetched = [];

        // validate all the language codes and discard invalid ones
    Severity: Minor
    Found in lib/includes/LanguageFallbackChainFactory.php - About 1 hr to fix

      Function addLanguageAndVariantsToChain has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function addLanguageAndVariantsToChain( $language, array &$chain, array &$fetched ): void {
        $languageCode = is_string( $language ) ? $language : $language->getCode();

        $this->addLanguageToChain( $language, $chain, $fetched );
      Severity: Minor
      Found in lib/includes/LanguageFallbackChainFactory.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function buildFromBabel has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function buildFromBabel( array $babel ) {
        $chain = [];
        $fetched = [];

        // validate all the language codes and discard invalid ones
      Severity: Minor
      Found in lib/includes/LanguageFallbackChainFactory.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status