Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
lib/includes/Store/Sql/Terms/DatabaseInnerTermStoreCleaner.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method cleanTextInLangIds has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function cleanTextInLangIds( array $textInLangIds ): void {
        if ( $textInLangIds === [] ) {
            return;
        }
Severity: Major
Found in lib/includes/Store/Sql/Terms/DatabaseInnerTermStoreCleaner.php - About 2 hrs to fix

    Method cleanTermInLangIdsInner has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function cleanTermInLangIdsInner( array $termInLangIds ): void {
        $this->logger->debug(
            '{method}: deleting {count} term_in_lang rows',
            [
                'method' => __METHOD__,
    Severity: Major
    Found in lib/includes/Store/Sql/Terms/DatabaseInnerTermStoreCleaner.php - About 2 hrs to fix

      Method selectFieldValuesForPrimaryKey has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function selectFieldValuesForPrimaryKey(
        string $table,
        string $selectedVar,
        string $primaryKeyVar,
        array $primaryKeyValues,
      Severity: Minor
      Found in lib/includes/Store/Sql/Terms/DatabaseInnerTermStoreCleaner.php - About 1 hr to fix

        Method selectFieldValuesForPrimaryKey has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                string $table,
        string $selectedVar,
        string $primaryKeyVar,
        array $primaryKeyValues,
        string $fname
        Severity: Minor
        Found in lib/includes/Store/Sql/Terms/DatabaseInnerTermStoreCleaner.php - About 35 mins to fix

          Function cleanTextInLangIds has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function cleanTextInLangIds( array $textInLangIds ): void {
        if ( $textInLangIds === [] ) {
            return;
        }
          Severity: Minor
          Found in lib/includes/Store/Sql/Terms/DatabaseInnerTermStoreCleaner.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function cleanTermInLangIdsInner has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function cleanTermInLangIdsInner( array $termInLangIds ): void {
        $this->logger->debug(
            '{method}: deleting {count} term_in_lang rows',
            [
                'method' => __METHOD__,
          Severity: Minor
          Found in lib/includes/Store/Sql/Terms/DatabaseInnerTermStoreCleaner.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status