wikimedia/mediawiki-extensions-Wikibase

View on GitHub
lib/includes/Store/Sql/Terms/DatabaseTermInLangIdsAcquirer.php

Summary

Maintainability
C
7 hrs
Test Coverage

File DatabaseTermInLangIdsAcquirer.php has 264 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Wikibase\Lib\Store\Sql\Terms;

use MediaWiki\MediaWikiServices;
Severity: Minor
Found in lib/includes/Store/Sql/Terms/DatabaseTermInLangIdsAcquirer.php - About 2 hrs to fix

    Method acquireTermInLangIdsInner has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function acquireTermInLangIdsInner(
            array $typeTextInLangIds,
            ReplicaPrimaryAwareRecordIdsAcquirer $termInLangIdsAcquirer,
            array $idsToRestore = []
        ) {
    Severity: Minor
    Found in lib/includes/Store/Sql/Terms/DatabaseTermInLangIdsAcquirer.php - About 1 hr to fix

      Function mapToTextInLangIds has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          private function mapToTextInLangIds(
              array $termsArray,
              ReplicaPrimaryAwareRecordIdsAcquirer $textInLangIdsAcquirer
          ) {
              $flattenedLangTextIds = [];
      Severity: Minor
      Found in lib/includes/Store/Sql/Terms/DatabaseTermInLangIdsAcquirer.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method mapToTextInLangIds has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function mapToTextInLangIds(
              array $termsArray,
              ReplicaPrimaryAwareRecordIdsAcquirer $textInLangIdsAcquirer
          ) {
              $flattenedLangTextIds = [];
      Severity: Minor
      Found in lib/includes/Store/Sql/Terms/DatabaseTermInLangIdsAcquirer.php - About 1 hr to fix

        Function mapToTermInLangIds has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function mapToTermInLangIds(
                array $termsArray,
                ReplicaPrimaryAwareRecordIdsAcquirer $termInLangIdsAcquirer,
                array $idsToRestore = []
            ) {
        Severity: Minor
        Found in lib/includes/Store/Sql/Terms/DatabaseTermInLangIdsAcquirer.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status