Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
lib/includes/Store/Sql/Terms/TermStoreWriterFactory.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

        DatabaseEntitySource $localEntitySource,
        StringNormalizer $stringNormalizer,
        TypeIdsAcquirer $typeIdsAcquirer,
        TypeIdsLookup $typeIdsLookup,
        TypeIdsResolver $typeIdsResolver,
Severity: Major
Found in lib/includes/Store/Sql/Terms/TermStoreWriterFactory.php - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function newPropertyTermStoreWriter(): PropertyTermStoreWriter {
        if ( !in_array( Property::ENTITY_TYPE, $this->localEntitySource->getEntityTypes() ) ) {
            throw new LogicException( 'Local entity source does not have properties.' );
        }
    Severity: Minor
    Found in lib/includes/Store/Sql/Terms/TermStoreWriterFactory.php and 1 other location - About 30 mins to fix
    lib/includes/Store/Sql/Terms/TermStoreWriterFactory.php on lines 87..99

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function newItemTermStoreWriter(): ItemTermStoreWriter {
        if ( !in_array( Item::ENTITY_TYPE, $this->localEntitySource->getEntityTypes() ) ) {
            throw new LogicException( 'Local entity source does not have items.' );
        }
    Severity: Minor
    Found in lib/includes/Store/Sql/Terms/TermStoreWriterFactory.php and 1 other location - About 30 mins to fix
    lib/includes/Store/Sql/Terms/TermStoreWriterFactory.php on lines 101..113

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status