Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
lib/includes/Store/Sql/WikiPageEntityDataLoader.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method loadEntityDataFromWikiPageRevision has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function loadEntityDataFromWikiPageRevision( RevisionRecord $revision, string $slotRole, int $revStoreFlags ) {
        // NOTE: Support for cross-wiki content access in RevisionStore is incomplete when,
        // reading from the pre-MCR database schema, see T201194.
        // For that reason, we have to load and decode the content blob directly,
        // instead of using RevisionRecord::getContent() or SlotRecord::getContent().
Severity: Minor
Found in lib/includes/Store/Sql/WikiPageEntityDataLoader.php - About 1 hr to fix

    Function loadEntityDataFromWikiPageRevision has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function loadEntityDataFromWikiPageRevision( RevisionRecord $revision, string $slotRole, int $revStoreFlags ) {
        // NOTE: Support for cross-wiki content access in RevisionStore is incomplete when,
        // reading from the pre-MCR database schema, see T201194.
        // For that reason, we have to load and decode the content blob directly,
        // instead of using RevisionRecord::getContent() or SlotRecord::getContent().
    Severity: Minor
    Found in lib/includes/Store/Sql/WikiPageEntityDataLoader.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status