Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method getEntityRevision has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getEntityRevision(
        EntityId $entityId,
        $revisionId = 0,
        $mode = LookupConstants::LATEST_FROM_REPLICA
    ) {
Severity: Major
Found in lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php - About 2 hrs to fix

    Function getEntityRevision has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getEntityRevision(
        EntityId $entityId,
        $revisionId = 0,
        $mode = LookupConstants::LATEST_FROM_REPLICA
    ) {
    Severity: Minor
    Found in lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getLatestRevisionId has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getLatestRevisionId( EntityId $entityId, $mode = LookupConstants::LATEST_FROM_REPLICA ) {
        $rows = $this->entityMetaDataAccessor->loadRevisionInformation( [ $entityId ], $mode );
        $row = $rows[$entityId->getSerialization()];

        if ( $row && $row->page_latest ) {
    Severity: Minor
    Found in lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status