Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
lib/packages/wikibase/data-model/src/ByPropertyIdArray.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function movePropertyGroup has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    private function movePropertyGroup( PropertyId $propertyId, $toIndex ) {
        if ( $this->getPropertyGroupIndex( $propertyId ) === $toIndex ) {
            return;
        }
Severity: Minor
Found in lib/packages/wikibase/data-model/src/ByPropertyIdArray.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method movePropertyGroup has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function movePropertyGroup( PropertyId $propertyId, $toIndex ) {
        if ( $this->getPropertyGroupIndex( $propertyId ) === $toIndex ) {
            return;
        }
Severity: Minor
Found in lib/packages/wikibase/data-model/src/ByPropertyIdArray.php - About 1 hr to fix

    Function addObjectToPropertyGroup has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private function addObjectToPropertyGroup( $object, $index = null ) {
        $propertyId = $object->getPropertyId();
        $validIndices = $this->getFlatArrayIndices( $propertyId );

        if ( empty( $validIndices ) ) {
    Severity: Minor
    Found in lib/packages/wikibase/data-model/src/ByPropertyIdArray.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function moveObjectToIndex has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function moveObjectToIndex( $object, $toIndex ) {
        $this->assertIndexIsBuild();

        if ( !in_array( $object, $this->toFlatArray() ) ) {
            throw new OutOfBoundsException( 'Object not present in array' );
    Severity: Minor
    Found in lib/packages/wikibase/data-model/src/ByPropertyIdArray.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status