Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/WikibaseRepo.entitytypes.php

Summary

Maintainability
C
1 day
Test Coverage

File WikibaseRepo.entitytypes.php has 489 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * Definition of entity types for use with Wikibase.
 * The array returned by the code below is supposed to be merged with the content of
Severity: Minor
Found in repo/WikibaseRepo.entitytypes.php - About 7 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                return new CombinedEntitySearchHelper(
                    [
                        new EntityIdSearchHelper(
                            WikibaseRepo::getEntityLookup(),
                            WikibaseRepo::getEntityIdParser(),
    Severity: Minor
    Found in repo/WikibaseRepo.entitytypes.php and 1 other location - About 40 mins to fix
    repo/WikibaseRepo.entitytypes.php on lines 427..446

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    new CombinedEntitySearchHelper(
                    [
                        new EntityIdSearchHelper(
                            WikibaseRepo::getEntityLookup(),
                            WikibaseRepo::getEntityIdParser(),
    Severity: Minor
    Found in repo/WikibaseRepo.entitytypes.php and 1 other location - About 40 mins to fix
    repo/WikibaseRepo.entitytypes.php on lines 224..242

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status