Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Actions/SubmitEntityAction.php

Summary

Maintainability
C
1 day
Test Coverage

Method undo has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function undo(): void {
        $request = $this->getRequest();
        $undidRevId = $request->getInt( 'undo' );
        $undidAfterRevId = $request->getInt( 'undoafter' );
        $restoreId = $request->getInt( 'restore' );
Severity: Major
Found in repo/includes/Actions/SubmitEntityAction.php - About 2 hrs to fix

    File SubmitEntityAction.php has 263 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

declare( strict_types = 1 );

namespace Wikibase\Repo\Actions;
    Severity: Minor
    Found in repo/includes/Actions/SubmitEntityAction.php - About 2 hrs to fix

      Function undo has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          public function undo(): void {
        $request = $this->getRequest();
        $undidRevId = $request->getInt( 'undo' );
        $undidAfterRevId = $request->getInt( 'undoafter' );
        $restoreId = $request->getInt( 'restore' );
      Severity: Minor
      Found in repo/includes/Actions/SubmitEntityAction.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              Article $article,
        IContextSource $context,
        PermissionManager $permissionManager,
        RevisionLookup $revisionLookup,
        TempUserCreator $tempUserCreator,
      Severity: Major
      Found in repo/includes/Actions/SubmitEntityAction.php - About 1 hr to fix

        Method attemptSave has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function attemptSave(
        Title $title,
        EntityContent $content,
        string $summary,
        int $undidRevId,
        Severity: Minor
        Found in repo/includes/Actions/SubmitEntityAction.php - About 1 hr to fix

          Method attemptSave has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  Title $title,
        EntityContent $content,
        string $summary,
        int $undidRevId,
        int $originalRevId,
          Severity: Minor
          Found in repo/includes/Actions/SubmitEntityAction.php - About 45 mins to fix

            Avoid too many return statements within this method.
            Open

                        return $status;
            Severity: Major
            Found in repo/includes/Actions/SubmitEntityAction.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return $status;
              Severity: Major
              Found in repo/includes/Actions/SubmitEntityAction.php - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status