Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Api/ModifyEntity.php

Summary

Maintainability
B
6 hrs
Test Coverage

File ModifyEntity.php has 275 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare( strict_types = 1 );

namespace Wikibase\Repo\Api;
Severity: Minor
Found in repo/includes/Api/ModifyEntity.php - About 2 hrs to fix

    Method execute has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function execute(): void {
        $params = $this->extractRequestParams();
        $user = $this->getUser();

        $this->validateParameters( $params );
    Severity: Minor
    Found in repo/includes/Api/ModifyEntity.php - About 1 hr to fix

      Method applyChangeOp has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function applyChangeOp( ChangeOp $changeOp, EntityDocument $entity, Summary $summary = null ): ChangeOpResult {
        try {
            // NOTE: Always validate modification against the current revision, if it exists!
            //       Otherwise, we may miss e.g. a combination of language/label/description
            //       that was already taken.
      Severity: Minor
      Found in repo/includes/Api/ModifyEntity.php - About 1 hr to fix

        Function validateParameters has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function validateParameters( array $params ): void {
        $entityReferenceBySiteLinkGiven = isset( $params['site'] ) && isset( $params['title'] );
        $entityReferenceBySiteLinkPartial = ( isset( $params['site'] ) xor isset( $params['title'] ) );
        $entityIdGiven = isset( $params['id'] );
        $shouldCreateNewWithSomeType = isset( $params['new'] );
        Severity: Minor
        Found in repo/includes/Api/ModifyEntity.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function applyChangeOp has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function applyChangeOp( ChangeOp $changeOp, EntityDocument $entity, Summary $summary = null ): ChangeOpResult {
        try {
            // NOTE: Always validate modification against the current revision, if it exists!
            //       Otherwise, we may miss e.g. a combination of language/label/description
            //       that was already taken.
        Severity: Minor
        Found in repo/includes/Api/ModifyEntity.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status