Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Api/SearchEntities.php

Summary

Maintainability
D
1 day
Test Coverage

File SearchEntities.php has 315 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare( strict_types = 1 );

namespace Wikibase\Repo\Api;
Severity: Minor
Found in repo/includes/Api/SearchEntities.php - About 3 hrs to fix

    Function buildTermSearchMatchPageEntry has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        private function buildTermSearchMatchPageEntry( TermSearchResult $match, ?array $props ): array {
        $entityId = $match->getEntityId();
        if ( $entityId !== null ) {
            $entry = [
                'id' => $entityId->getSerialization(),
    Severity: Minor
    Found in repo/includes/Api/SearchEntities.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method executeInternal has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function executeInternal(): void {
        $this->getMain()->setCacheMode( 'public' );

        $params = $this->extractRequestParams();
    Severity: Minor
    Found in repo/includes/Api/SearchEntities.php - About 1 hr to fix

      Method getAllowedParams has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getAllowedParams(): array {
        return [
            'search' => [
                ParamValidator::PARAM_TYPE => 'string',
                ParamValidator::PARAM_REQUIRED => true,
      Severity: Minor
      Found in repo/includes/Api/SearchEntities.php - About 1 hr to fix

        Method __construct has 13 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                ApiMain $mainModule,
        string $moduleName,
        LinkBatchFactory $linkBatchFactory,
        EntitySearchHelper $entitySearchHelper,
        ContentLanguages $termLanguages,
        Severity: Major
        Found in repo/includes/Api/SearchEntities.php - About 1 hr to fix

          Method factory has 13 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  ApiMain $mainModule,
        string $moduleName,
        LinkBatchFactory $linkBatchFactory,
        ApiHelperFactory $apiHelperFactory,
        array $enabledEntityTypes,
          Severity: Major
          Found in repo/includes/Api/SearchEntities.php - About 1 hr to fix

            Method buildTermSearchMatchPageEntry has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function buildTermSearchMatchPageEntry( TermSearchResult $match, ?array $props ): array {
        $entityId = $match->getEntityId();
        if ( $entityId !== null ) {
            $entry = [
                'id' => $entityId->getSerialization(),
            Severity: Minor
            Found in repo/includes/Api/SearchEntities.php - About 1 hr to fix

              Method buildTermSearchMatchDisplayEntry has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function buildTermSearchMatchDisplayEntry( TermSearchResult $match, array $entry ): array {
        $entry['display'] = [];
        ApiResult::setArrayType( $entry['display'], 'assoc' );

        $displayLabel = $match->getDisplayLabel();
              Severity: Minor
              Found in repo/includes/Api/SearchEntities.php - About 1 hr to fix

                Function buildTermSearchMatchDisplayEntry has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function buildTermSearchMatchDisplayEntry( TermSearchResult $match, array $entry ): array {
        $entry['display'] = [];
        ApiResult::setArrayType( $entry['display'], 'assoc' );

        $displayLabel = $match->getDisplayLabel();
                Severity: Minor
                Found in repo/includes/Api/SearchEntities.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                There are no issues that match your filters.

                Category
                Status