Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Api/SetAliases.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        ApiMain $mainModule,
        string $moduleName,
        FingerprintChangeOpFactory $termChangeOpFactory,
        IBufferingStatsdDataFactory $stats,
        bool $federatedPropertiesEnabled,
Severity: Major
Found in repo/includes/Api/SetAliases.php - About 50 mins to fix

    Method factory has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            ApiMain $mainModule,
        string $moduleName,
        IBufferingStatsdDataFactory $stats,
        ChangeOpFactoryProvider $changeOpFactoryProvider,
        EntityFactory $entityFactory,
    Severity: Minor
    Found in repo/includes/Api/SetAliases.php - About 45 mins to fix

      Function getChangeOp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getChangeOp( array $preparedParameters, EntityDocument $entity ): ChangeOp {
        $changeOps = [];
        $language = $preparedParameters['language'];

        // Set the list of aliases to a user given one OR add/ remove certain entries
      Severity: Minor
      Found in repo/includes/Api/SetAliases.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status