Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Api/SetClaim.php

Summary

Maintainability
C
1 day
Test Coverage

File SetClaim.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare( strict_types = 1 );

namespace Wikibase\Repo\Api;
Severity: Minor
Found in repo/includes/Api/SetClaim.php - About 2 hrs to fix

    Method executeInternal has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function executeInternal(): void {
        $params = $this->extractRequestParams();
        $statement = $this->getStatementFromParams( $params );
        $guid = $statement->getGuid();
    Severity: Minor
    Found in repo/includes/Api/SetClaim.php - About 1 hr to fix

      Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              ApiMain $mainModule,
        string $moduleName,
        ApiErrorReporter $errorReporter,
        Deserializer $statementDeserializer,
        StatementChangeOpFactory $statementChangeOpFactory,
      Severity: Major
      Found in repo/includes/Api/SetClaim.php - About 1 hr to fix

        Method factory has 11 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                ApiMain $mainModule,
        string $moduleName,
        IBufferingStatsdDataFactory $stats,
        ApiHelperFactory $apiHelperFactory,
        ChangeOpFactoryProvider $changeOpFactoryProvider,
        Severity: Major
        Found in repo/includes/Api/SetClaim.php - About 1 hr to fix

          Method getAllowedParams has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function getAllowedParams(): array {
        return array_merge(
            [
                'claim' => [
                    ParamValidator::PARAM_TYPE => 'text',
          Severity: Minor
          Found in repo/includes/Api/SetClaim.php - About 1 hr to fix

            Function executeInternal has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private function executeInternal(): void {
        $params = $this->extractRequestParams();
        $statement = $this->getStatementFromParams( $params );
        $guid = $statement->getGuid();
            Severity: Minor
            Found in repo/includes/Api/SetClaim.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function statementMainSnakAlreadyExists has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private function statementMainSnakAlreadyExists(
        Statement $statement,
        StatementList $existingStatements
    ): bool {
        $propertyId = $statement->getPropertyId();
            Severity: Minor
            Found in repo/includes/Api/SetClaim.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status