Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/ChangeModification/DispatchChangesJob.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method run has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run(): bool {
        // TODO: for v2 of this job, we could actually get all the newest revision from the DB,
        //       calculate the change_info ourselves and thus make wb_changes table obsolete?

        $repoSettings = WikibaseRepo::getSettings();
Severity: Minor
Found in repo/includes/ChangeModification/DispatchChangesJob.php - About 1 hr to fix

    Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            SubscriptionLookup $subscriptionLookup,
        EntityChangeLookup $changeLookup,
        EntityIdParser $entityIdParser,
        JobQueueGroupFactory $jobQueueGroupFactory,
        ChangeStore $changeStore,
    Severity: Major
    Found in repo/includes/ChangeModification/DispatchChangesJob.php - About 1 hr to fix

      Function getClientWikis has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getClientWikis( SettingsArray $repoSettings ): array {
        $clientWikis = $repoSettings->getSetting( 'localClientDatabases' );
        // make sure we have a mapping from siteId to database name in clientWikis:
        foreach ( $clientWikis as $siteID => $dbName ) {
            if ( is_int( $siteID ) ) {
      Severity: Minor
      Found in repo/includes/ChangeModification/DispatchChangesJob.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status