Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/ChangeOp/Deserialization/SiteLinkBadgeChangeOpSerializationValidator.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function validateBadgeSerialization has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function validateBadgeSerialization( array $serialization ) {
        foreach ( $serialization as $badgeSerialization ) {
            if ( !is_string( $badgeSerialization ) ) {
                throw new ChangeOpDeserializationException(
                    'Badges: a string was expected, but not found',
Severity: Minor
Found in repo/includes/ChangeOp/Deserialization/SiteLinkBadgeChangeOpSerializationValidator.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validateBadgeSerialization has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function validateBadgeSerialization( array $serialization ) {
        foreach ( $serialization as $badgeSerialization ) {
            if ( !is_string( $badgeSerialization ) ) {
                throw new ChangeOpDeserializationException(
                    'Badges: a string was expected, but not found',
Severity: Minor
Found in repo/includes/ChangeOp/Deserialization/SiteLinkBadgeChangeOpSerializationValidator.php - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status