wikimedia/mediawiki-extensions-Wikibase

View on GitHub
repo/includes/Content/EntityContent.php

Summary

Maintainability
C
1 day
Test Coverage

EntityContent has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class EntityContent extends AbstractContent {

    /**
     * Flag for use with EntityHandler::validateSave(), indicating that no pre-save validation should be applied.
     * Can be passed in via EditEntity::attemptSave, EntityStore::saveEntity,
Severity: Minor
Found in repo/includes/Content/EntityContent.php - About 2 hrs to fix

    Function equals has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function equals( Content $that = null ) {
            if ( $that === $this ) {
                return true;
            }
    
    
    Severity: Minor
    Found in repo/includes/Content/EntityContent.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method equals has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function equals( Content $that = null ) {
            if ( $that === $this ) {
                return true;
            }
    
    
    Severity: Minor
    Found in repo/includes/Content/EntityContent.php - About 1 hr to fix

      Function getPatchedCopy has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getPatchedCopy( EntityContentDiff $patch ) {
              $handler = $this->getContentHandler();
      
              $redirAfterPatch = $this->getPatchedRedirect( $patch->getRedirectDiff() );
      
      
      Severity: Minor
      Found in repo/includes/Content/EntityContent.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return false;
      Severity: Major
      Found in repo/includes/Content/EntityContent.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return true;
        Severity: Major
        Found in repo/includes/Content/EntityContent.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $thisHolder->getEntity()->equals( $thatHolder->getEntity() );
          Severity: Major
          Found in repo/includes/Content/EntityContent.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return false;
            Severity: Major
            Found in repo/includes/Content/EntityContent.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return false;
              Severity: Major
              Found in repo/includes/Content/EntityContent.php - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status