Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Content/EntityHandler.php

Summary

Maintainability
D
1 day
Test Coverage

EntityHandler has 47 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class EntityHandler extends ContentHandler {

    /**
     * Added to parser options for EntityContent.
     *
Severity: Minor
Found in repo/includes/Content/EntityHandler.php - About 6 hrs to fix

    File EntityHandler.php has 428 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Wikibase\Repo\Content;

use Article;
    Severity: Minor
    Found in repo/includes/Content/EntityHandler.php - About 6 hrs to fix

      Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              $modelId,
        $unused,
        EntityContentDataCodec $contentCodec,
        EntityConstraintProvider $constraintProvider,
        ValidatorErrorLocalizer $errorLocalizer,
      Severity: Major
      Found in repo/includes/Content/EntityHandler.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                    return $patchedCurrent;
        Severity: Major
        Found in repo/includes/Content/EntityHandler.php - About 30 mins to fix

          Function applyEntityPageProperties has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function applyEntityPageProperties( EntityContent $content, ParserOutput $parserOutput ) {
        if ( $content->isRedirect() ) {
            return;
        }
          Severity: Minor
          Found in repo/includes/Content/EntityHandler.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getUndoContent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getUndoContent(
        Content $latestContent,
        Content $newerContent,
        Content $olderContent,
        $undoIsLatest = false
          Severity: Minor
          Found in repo/includes/Content/EntityHandler.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status