Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Diff/SiteLinkDiffView.php

Summary

Maintainability
C
1 day
Test Coverage

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        array $path,
        Diff $diff,
        SiteLookup $siteLookup,
        EntityIdFormatter $entityIdFormatter,
        MessageLocalizer $messageLocalizer
Severity: Minor
Found in repo/includes/Diff/SiteLinkDiffView.php - About 35 mins to fix

    Function generateOpHtml has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function generateOpHtml( array $path, DiffOp $op ): string {
        if ( $op instanceof AtomicDiffOp ) {
            $localizedPath = $path;

            $translatedLinkSubPath = $this->messageLocalizer->msg(
    Severity: Minor
    Found in repo/includes/Diff/SiteLinkDiffView.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        protected function generateHtmlDiffTableRow( ?string $oldHtml, ?string $newHtml ): string {
        $html = Html::openElement( 'tr' );
        if ( $oldHtml !== null ) {
            $html .= Html::element( 'td', [ 'class' => 'diff-marker', 'data-marker' => '−' ] );
            $html .= Html::rawElement( 'td', [ 'class' => 'diff-deletedline' ],
    Severity: Major
    Found in repo/includes/Diff/SiteLinkDiffView.php and 1 other location - About 1 day to fix
    repo/includes/Diff/BasicDiffView.php on lines 113..131

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 245.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        protected function generateDiffHeaderHtml( string $name ): string {
        $html = Html::openElement( 'tr' );
        $html .= Html::element( 'td', [ 'colspan' => '2', 'class' => 'diff-lineno' ], $name );
        // @phan-suppress-next-line PhanPluginDuplicateAdjacentStatement
        $html .= Html::element( 'td', [ 'colspan' => '2', 'class' => 'diff-lineno' ], $name );
    Severity: Major
    Found in repo/includes/Diff/SiteLinkDiffView.php and 1 other location - About 1 hr to fix
    repo/includes/Diff/BasicDiffView.php on lines 148..156

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status