Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php

Summary

Maintainability
D
2 days
Test Coverage

File HtmlPageLinkRendererEndHookHandler.php has 300 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare( strict_types = 1 );

namespace Wikibase\Repo\Hooks;
Severity: Minor
Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php - About 3 hrs to fix

    Method internalDoHtmlPageLinkRendererEnd has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function internalDoHtmlPageLinkRendererEnd(
        LinkRenderer $linkRenderer,
        Title $target,
        &$text,
        array &$customAttribs,
    Severity: Major
    Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php - About 2 hrs to fix

      Method __construct has 13 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              EntityExistenceChecker $entityExistenceChecker,
        EntityIdParser $entityIdParser,
        TermLookup $termLookup,
        EntityNamespaceLookup $localEntityNamespaceLookup,
        InterwikiLookup $interwikiLookup,
      Severity: Major
      Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php - About 1 hr to fix

        Function internalDoHtmlPageLinkRendererEnd has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            private function internalDoHtmlPageLinkRendererEnd(
        LinkRenderer $linkRenderer,
        Title $target,
        &$text,
        array &$customAttribs,
        Severity: Minor
        Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method factory has 12 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                InterwikiLookup $interwikiLookup,
        SpecialPageFactory $specialPageFactory,
        EntityExistenceChecker $entityExistenceChecker,
        EntityIdParser $entityIdParser,
        EntityLinkFormatterFactory $entityLinkFormatterFactory,
        Severity: Major
        Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php - About 1 hr to fix

          Method onHtmlPageLinkRendererEnd has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $linkRenderer,
        $target,
        $isKnown,
        &$text,
        &$extraAttribs,
          Severity: Minor
          Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php - About 45 mins to fix

            Method doHtmlPageLinkRendererEnd has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    LinkRenderer $linkRenderer,
        Title $target,
        &$text,
        array &$customAttribs,
        RequestContext $context,
            Severity: Minor
            Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php - About 45 mins to fix

              Method internalDoHtmlPageLinkRendererEnd has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      LinkRenderer $linkRenderer,
        Title $target,
        &$text,
        array &$customAttribs,
        RequestContext $context,
              Severity: Minor
              Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php - About 45 mins to fix

                Avoid too many return statements within this method.
                Open

                        return true;
                Severity: Major
                Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return false;
                  Severity: Major
                  Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return true;
                    Severity: Major
                    Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return true;
                      Severity: Major
                      Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return true;
                        Severity: Major
                        Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php - About 30 mins to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function __construct(
        EntityExistenceChecker $entityExistenceChecker,
        EntityIdParser $entityIdParser,
        TermLookup $termLookup,
        EntityNamespaceLookup $localEntityNamespaceLookup,
                          Severity: Major
                          Found in repo/includes/Hooks/HtmlPageLinkRendererEndHookHandler.php and 1 other location - About 1 hr to fix
                          client/includes/DataAccess/Scribunto/WikibaseLanguageIndependentLuaBindings.php on lines 105..133

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 118.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status