wikimedia/mediawiki-extensions-Wikibase

View on GitHub
repo/includes/Hooks/SidebarBeforeOutputHookHandler.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        string $baseConceptUri,
        EntityIdLookup $idLookup,
        EntityLookup $entityLookup,
        EntityNamespaceLookup $nsLookup,
        LoggerInterface $logger
Severity: Minor
Found in repo/includes/Hooks/SidebarBeforeOutputHookHandler.php - About 35 mins to fix

    Avoid too many return statements within this method.
    Open

                    return null;
    Severity: Major
    Found in repo/includes/Hooks/SidebarBeforeOutputHookHandler.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return $entityId;
      Severity: Major
      Found in repo/includes/Hooks/SidebarBeforeOutputHookHandler.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return null;
        Severity: Major
        Found in repo/includes/Hooks/SidebarBeforeOutputHookHandler.php - About 30 mins to fix

          Function getValidEntityId has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getValidEntityId( ?Title $title ): ?EntityId {
                  if ( $title === null ) {
                      return null;
                  }
          
          
          Severity: Minor
          Found in repo/includes/Hooks/SidebarBeforeOutputHookHandler.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status