Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Interactors/EntityRedirectCreationInteractor.php

Summary

Maintainability
C
1 day
Test Coverage

Method saveRedirect has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function saveRedirect(
        EntityRedirect $redirect,
        FormatableSummary $summary,
        IContextSource $context,
        bool $bot,
Severity: Minor
Found in repo/includes/Interactors/EntityRedirectCreationInteractor.php - About 1 hr to fix

    Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            EntityRevisionLookup $entityRevisionLookup,
        EntityStore $entityStore,
        EntityPermissionChecker $permissionChecker,
        SummaryFormatter $summaryFormatter,
        EditFilterHookRunner $editFilterHookRunner,
    Severity: Major
    Found in repo/includes/Interactors/EntityRedirectCreationInteractor.php - About 1 hr to fix

      Function saveRedirect has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          private function saveRedirect(
        EntityRedirect $redirect,
        FormatableSummary $summary,
        IContextSource $context,
        bool $bot,
      Severity: Minor
      Found in repo/includes/Interactors/EntityRedirectCreationInteractor.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method createRedirect has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              EntityId $fromId,
        EntityId $toId,
        bool $bot,
        array $tags,
        IContextSource $context
      Severity: Minor
      Found in repo/includes/Interactors/EntityRedirectCreationInteractor.php - About 35 mins to fix

        Method saveRedirect has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                EntityRedirect $redirect,
        FormatableSummary $summary,
        IContextSource $context,
        bool $bot,
        array $tags
        Severity: Minor
        Found in repo/includes/Interactors/EntityRedirectCreationInteractor.php - About 35 mins to fix

          Function checkCanCreateRedirect has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function checkCanCreateRedirect( EntityId $entityId ): void {
        try {
            $revision = $this->entityRevisionLookup->getEntityRevision(
                $entityId,
                0,
          Severity: Minor
          Found in repo/includes/Interactors/EntityRedirectCreationInteractor.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

              public function __construct(
        EntityRevisionLookup $entityRevisionLookup,
        EntityStore $entityStore,
        EntityPermissionChecker $permissionChecker,
        SummaryFormatter $summaryFormatter,
          Severity: Major
          Found in repo/includes/Interactors/EntityRedirectCreationInteractor.php and 4 other locations - About 2 hrs to fix
          repo/includes/ChangeOp/StatementChangeOpFactory.php on lines 59..77
          repo/includes/Interactors/ItemMergeInteractor.php on lines 48..66
          repo/rest-api/src/Application/UseCases/PatchStatement/PatchStatement.php on lines 34..52
          repo/rest-api/src/Infrastructure/DataAccess/EntityUpdater.php on lines 44..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 132.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status