Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Specials/SpecialItemByTitle.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method switchForm has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function switchForm( $siteId, $page ) {
        $siteExists = $siteId
            && $this->siteLinkTargetProvider->getSiteList( $this->groups )->hasSite( $siteId );

        $this->logger->debug(
Severity: Major
Found in repo/includes/Specials/SpecialItemByTitle.php - About 2 hrs to fix

    Function execute has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public function execute( $subPage ) {
        parent::execute( $subPage );

        // Setup
        $request = $this->getRequest();
    Severity: Minor
    Found in repo/includes/Specials/SpecialItemByTitle.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method execute has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function execute( $subPage ) {
        parent::execute( $subPage );

        // Setup
        $request = $this->getRequest();
    Severity: Minor
    Found in repo/includes/Specials/SpecialItemByTitle.php - About 1 hr to fix

      Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              EntityTitleLookup $titleLookup,
        LanguageNameLookup $languageNameLookup,
        SiteLookup $siteLookup,
        SiteLinkLookup $siteLinkLookup,
        SiteLinkTargetProvider $siteLinkTargetProvider,
      Severity: Major
      Found in repo/includes/Specials/SpecialItemByTitle.php - About 50 mins to fix

        Method factory has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                SiteLookup $siteLookup,
        EntityTitleLookup $entityTitleLookup,
        LanguageNameLookupFactory $languageNameLookupFactory,
        LoggerInterface $logger,
        SettingsArray $repoSettings,
        Severity: Minor
        Found in repo/includes/Specials/SpecialItemByTitle.php - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status