Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Specials/SpecialNewItem.php

Summary

Maintainability
F
3 days
Test Coverage

File SpecialNewItem.php has 340 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare( strict_types = 1 );

namespace Wikibase\Repo\Specials;
Severity: Minor
Found in repo/includes/Specials/SpecialNewItem.php - About 4 hrs to fix

    Method getFormFields has 81 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function getFormFields(): array {
        $formFields = [
            self::FIELD_LANG => [
                'name' => self::FIELD_LANG,
                'class' => HTMLContentLanguageField::class,
    Severity: Major
    Found in repo/includes/Specials/SpecialNewItem.php - About 3 hrs to fix

      Method validateFormData has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function validateFormData( array $formData ): Status {
        $status = Status::newGood();

        if ( $formData[ self::FIELD_LABEL ] == ''
             && $formData[ self::FIELD_DESCRIPTION ] == ''
      Severity: Major
      Found in repo/includes/Specials/SpecialNewItem.php - About 2 hrs to fix

        Method __construct has 16 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                array $tags,
        SpecialPageCopyrightView $copyrightView,
        EntityNamespaceLookup $entityNamespaceLookup,
        SummaryFormatter $summaryFormatter,
        EntityTitleLookup $entityTitleLookup,
        Severity: Major
        Found in repo/includes/Specials/SpecialNewItem.php - About 2 hrs to fix

          Method factory has 13 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  AnonymousEditWarningBuilder $anonymousEditWarningBuilder,
        MediaWikiEditEntityFactory $editEntityFactory,
        EntityNamespaceLookup $entityNamespaceLookup,
        EntityTitleLookup $entityTitleLookup,
        FallbackLabelDescriptionLookupFactory $labelDescriptionLookupFactory,
          Severity: Major
          Found in repo/includes/Specials/SpecialNewItem.php - About 1 hr to fix

            Function validateFormData has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function validateFormData( array $formData ): Status {
        $status = Status::newGood();

        if ( $formData[ self::FIELD_LABEL ] == ''
             && $formData[ self::FIELD_DESCRIPTION ] == ''
            Severity: Minor
            Found in repo/includes/Specials/SpecialNewItem.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getFormFields has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function getFormFields(): array {
        $formFields = [
            self::FIELD_LANG => [
                'name' => self::FIELD_LANG,
                'class' => HTMLContentLanguageField::class,
            Severity: Minor
            Found in repo/includes/Specials/SpecialNewItem.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return $formFields;
            Severity: Major
            Found in repo/includes/Specials/SpecialNewItem.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return true;
              Severity: Major
              Found in repo/includes/Specials/SpecialNewItem.php - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        $formFields = [
            self::FIELD_LANG => [
                'name' => self::FIELD_LANG,
                'class' => HTMLContentLanguageField::class,
                'id' => 'wb-newentity-language',
                Severity: Major
                Found in repo/includes/Specials/SpecialNewItem.php and 1 other location - About 4 hrs to fix
                repo/includes/Specials/SpecialNewProperty.php on lines 163..190

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 178.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( $formData[self::FIELD_ALIASES] !== [] ) {
            $validator = $this->termValidatorFactory->getAliasValidator();
            foreach ( $formData[self::FIELD_ALIASES] as $alias ) {
                $result = $validator->validate( $alias );
                $status->merge( $this->errorLocalizer->getResultStatus( $result ) );
                Severity: Major
                Found in repo/includes/Specials/SpecialNewItem.php and 1 other location - About 4 hrs to fix
                repo/includes/Specials/SpecialNewProperty.php on lines 282..295

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 168.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( $formData[self::FIELD_LABEL] != '' ) {
            $validator = $this->termValidatorFactory->getLabelValidator( $this->getEntityType() );
            $result = $validator->validate( $formData[self::FIELD_LABEL] );
            $status->merge( $this->errorLocalizer->getResultStatus( $result ) );
                Severity: Major
                Found in repo/includes/Specials/SpecialNewItem.php and 1 other location - About 1 hr to fix
                repo/includes/Specials/SpecialNewProperty.php on lines 262..270

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 120.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( $formData[self::FIELD_DESCRIPTION] != '' ) {
            $validator = $this->termValidatorFactory->getDescriptionValidator();
            $result = $validator->validate( $formData[self::FIELD_DESCRIPTION] );
            $status->merge( $this->errorLocalizer->getResultStatus( $result ) );
                Severity: Major
                Found in repo/includes/Specials/SpecialNewItem.php and 1 other location - About 1 hr to fix
                repo/includes/Specials/SpecialNewProperty.php on lines 272..280

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 114.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    protected function createSummary( EntityDocument $item ): Summary {
        $uiLanguageCode = $this->getLanguage()->getCode();

        $summary = new Summary( 'wbeditentity', 'create' );
        $summary->setLanguage( $uiLanguageCode );
                Severity: Major
                Found in repo/includes/Specials/SpecialNewItem.php and 1 other location - About 1 hr to fix
                repo/includes/Specials/SpecialNewProperty.php on lines 323..338

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 105.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status