Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Specials/SpecialNewProperty.php

Summary

Maintainability
D
3 days
Test Coverage

Method validateFormData has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function validateFormData( array $formData ) {
        $status = Status::newGood();

        if ( $formData[ self::FIELD_LABEL ] == ''
             && $formData[ self::FIELD_DESCRIPTION ] == ''
Severity: Major
Found in repo/includes/Specials/SpecialNewProperty.php - About 2 hrs to fix

    File SpecialNewProperty.php has 252 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Wikibase\Repo\Specials;

use MediaWiki\Output\OutputPage;
    Severity: Minor
    Found in repo/includes/Specials/SpecialNewProperty.php - About 2 hrs to fix

      Method getFormFields has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getFormFields() {
        $formFields = [
            self::FIELD_LANG => [
                'name' => self::FIELD_LANG,
                'class' => HTMLContentLanguageField::class,
      Severity: Minor
      Found in repo/includes/Specials/SpecialNewProperty.php - About 2 hrs to fix

        Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                array $tags,
        SpecialPageCopyrightView $specialPageCopyrightView,
        EntityNamespaceLookup $entityNamespaceLookup,
        SummaryFormatter $summaryFormatter,
        EntityTitleLookup $entityTitleLookup,
        Severity: Major
        Found in repo/includes/Specials/SpecialNewProperty.php - About 1 hr to fix

          Function validateFormData has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function validateFormData( array $formData ) {
        $status = Status::newGood();

        if ( $formData[ self::FIELD_LABEL ] == ''
             && $formData[ self::FIELD_DESCRIPTION ] == ''
          Severity: Minor
          Found in repo/includes/Specials/SpecialNewProperty.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method factory has 11 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  AnonymousEditWarningBuilder $anonymousEditWarningBuilder,
        DataTypeFactory $dataTypeFactory,
        MediaWikiEditEntityFactory $editEntityFactory,
        EntityNamespaceLookup $entityNamespaceLookup,
        EntityTitleLookup $entityTitleLookup,
          Severity: Major
          Found in repo/includes/Specials/SpecialNewProperty.php - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    $formFields = [
            self::FIELD_LANG => [
                'name' => self::FIELD_LANG,
                'class' => HTMLContentLanguageField::class,
                'id' => 'wb-newentity-language',
            Severity: Major
            Found in repo/includes/Specials/SpecialNewProperty.php and 1 other location - About 4 hrs to fix
            repo/includes/Specials/SpecialNewItem.php on lines 196..223

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 178.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if ( $formData[self::FIELD_ALIASES] !== [] ) {
            $validator = $this->termValidatorFactory->getAliasValidator();
            foreach ( $formData[self::FIELD_ALIASES] as $alias ) {
                $result = $validator->validate( $alias );
                $status->merge( $this->errorLocalizer->getResultStatus( $result ) );
            Severity: Major
            Found in repo/includes/Specials/SpecialNewProperty.php and 1 other location - About 4 hrs to fix
            repo/includes/Specials/SpecialNewItem.php on lines 367..380

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 168.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if ( $formData[self::FIELD_LABEL] != '' ) {
            $validator = $this->termValidatorFactory->getLabelValidator( $this->getEntityType() );
            $result = $validator->validate( $formData[self::FIELD_LABEL] );
            $status->merge( $this->errorLocalizer->getResultStatus( $result ) );
            Severity: Major
            Found in repo/includes/Specials/SpecialNewProperty.php and 1 other location - About 1 hr to fix
            repo/includes/Specials/SpecialNewItem.php on lines 347..355

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 120.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if ( $formData[self::FIELD_DESCRIPTION] != '' ) {
            $validator = $this->termValidatorFactory->getDescriptionValidator();
            $result = $validator->validate( $formData[self::FIELD_DESCRIPTION] );
            $status->merge( $this->errorLocalizer->getResultStatus( $result ) );
            Severity: Major
            Found in repo/includes/Specials/SpecialNewProperty.php and 1 other location - About 1 hr to fix
            repo/includes/Specials/SpecialNewItem.php on lines 357..365

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 114.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                protected function createSummary( EntityDocument $property ) {
        $uiLanguageCode = $this->getLanguage()->getCode();

        $summary = new Summary( 'wbeditentity', 'create' );
        $summary->setLanguage( $uiLanguageCode );
            Severity: Major
            Found in repo/includes/Specials/SpecialNewProperty.php and 1 other location - About 1 hr to fix
            repo/includes/Specials/SpecialNewItem.php on lines 415..430

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status