Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Specials/SpecialSetLabelDescriptionAliases.php

Summary

Maintainability
D
2 days
Test Coverage

File SpecialSetLabelDescriptionAliases.php has 368 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Wikibase\Repo\Specials;

use InvalidArgumentException;
Severity: Minor
Found in repo/includes/Specials/SpecialSetLabelDescriptionAliases.php - About 4 hrs to fix

    SpecialSetLabelDescriptionAliases has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class SpecialSetLabelDescriptionAliases extends SpecialModifyEntity {

    use ParameterizedDescriptionTrait;

    public const BUTTON_MESSAGE_PUBLISH = 'publishchanges';
    Severity: Minor
    Found in repo/includes/Specials/SpecialSetLabelDescriptionAliases.php - About 2 hrs to fix

      Method getForm has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getForm( EntityDocument $entity = null ) {
        if ( $this->isEditFormStep( $entity ) ) {

            $languageName = $this->languageNameUtils->getLanguageName(
                $this->languageCode, $this->getLanguage()->getCode()
      Severity: Minor
      Found in repo/includes/Specials/SpecialSetLabelDescriptionAliases.php - About 1 hr to fix

        Method getChangeOps has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function getChangeOps( Fingerprint $fingerprint ) {
        $changeOpFactory = $this->changeOpFactory;
        $changeOps = [];

        if ( $this->label !== '' ) {
        Severity: Minor
        Found in repo/includes/Specials/SpecialSetLabelDescriptionAliases.php - About 1 hr to fix

          Function getChangeOps has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getChangeOps( Fingerprint $fingerprint ) {
        $changeOpFactory = $this->changeOpFactory;
        $changeOps = [];

        if ( $this->label !== '' ) {
          Severity: Minor
          Found in repo/includes/Specials/SpecialSetLabelDescriptionAliases.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 11 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  array $tags,
        SpecialPageCopyrightView $copyrightView,
        SummaryFormatter $summaryFormatter,
        EntityTitleLookup $entityTitleLookup,
        MediaWikiEditEntityFactory $editEntityFactory,
          Severity: Major
          Found in repo/includes/Specials/SpecialSetLabelDescriptionAliases.php - About 1 hr to fix

            Method factory has 10 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    LanguageNameUtils $languageNameUtils,
        Config $mwConfig,
        AnonymousEditWarningBuilder $anonymousEditWarningBuilder,
        ChangeOpFactoryProvider $changeOpFactoryProvider,
        MediaWikiEditEntityFactory $editEntityFactory,
            Severity: Major
            Found in repo/includes/Specials/SpecialSetLabelDescriptionAliases.php - About 1 hr to fix

              Function assertNoPipeCharacterInAliases has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function assertNoPipeCharacterInAliases( Fingerprint $fingerprint ) {
        if ( $this->aliases ) {
            if ( $fingerprint->hasAliasGroup( $this->languageCode ) ) {
                $aliasesInLang = $fingerprint->getAliasGroup( $this->languageCode )->getAliases();
                foreach ( $aliasesInLang as $alias ) {
              Severity: Minor
              Found in repo/includes/Specials/SpecialSetLabelDescriptionAliases.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function processArguments has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function processArguments( $subPage ) {
        $this->extractInput( $subPage );

        // Parse the 'id' parameter and throw an exception if the entity cannot be loaded
        parent::processArguments( $subPage );
              Severity: Minor
              Found in repo/includes/Specials/SpecialSetLabelDescriptionAliases.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ( $this->label !== '' ) {
            if ( !$fingerprint->hasLabel( $this->languageCode )
                || $fingerprint->getLabel( $this->languageCode )->getText() !== $this->label
            ) {
                $changeOps['wbsetlabel'] = $changeOpFactory->newSetLabelOp(
              Severity: Major
              Found in repo/includes/Specials/SpecialSetLabelDescriptionAliases.php and 1 other location - About 1 hr to fix
              repo/includes/Specials/SpecialSetLabelDescriptionAliases.php on lines 486..499

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 102.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if ( $this->description !== '' ) {
            if ( !$fingerprint->hasDescription( $this->languageCode )
                || $fingerprint->getDescription( $this->languageCode )->getText() !== $this->description
            ) {
                $changeOps['wbsetdescription'] = $changeOpFactory->newSetDescriptionOp(
              Severity: Major
              Found in repo/includes/Specials/SpecialSetLabelDescriptionAliases.php and 1 other location - About 1 hr to fix
              repo/includes/Specials/SpecialSetLabelDescriptionAliases.php on lines 471..484

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 102.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status