Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Store/Sql/SqlIdGenerator.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method generateNewId has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function generateNewId( IDatabase $database, $type, $retry = true ) {
        $database->startAtomic( __METHOD__ );

        $currentId = $database->newSelectQueryBuilder()
            ->select( 'id_value' )
Severity: Minor
Found in repo/includes/Store/Sql/SqlIdGenerator.php - About 1 hr to fix

    Function generateNewId has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function generateNewId( IDatabase $database, $type, $retry = true ) {
        $database->startAtomic( __METHOD__ );

        $currentId = $database->newSelectQueryBuilder()
            ->select( 'id_value' )
    Severity: Minor
    Found in repo/includes/Store/Sql/SqlIdGenerator.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status