Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/includes/Store/WikiPageEntityStorePermissionChecker.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function getMediaWikiPermissionsToCheck has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    private function getMediaWikiPermissionsToCheck( $action, $entityType ) {
        if ( $action === self::ACTION_MW_CREATE ) {
            $entityTypeSpecificCreatePermission = $entityType . '-create';

            $permissions = [ 'read', 'edit', 'createpage' ];
Severity: Minor
Found in repo/includes/Store/WikiPageEntityStorePermissionChecker.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getMediaWikiPermissionsToCheck has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getMediaWikiPermissionsToCheck( $action, $entityType ) {
        if ( $action === self::ACTION_MW_CREATE ) {
            $entityTypeSpecificCreatePermission = $entityType . '-create';

            $permissions = [ 'read', 'edit', 'createpage' ];
Severity: Minor
Found in repo/includes/Store/WikiPageEntityStorePermissionChecker.php - About 1 hr to fix

    Method checkPermissionsForActions has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            User $user,
        array $actions,
        Title $title,
        $entityType,
        $rigor = PermissionManager::RIGOR_SECURE
    Severity: Minor
    Found in repo/includes/Store/WikiPageEntityStorePermissionChecker.php - About 35 mins to fix

      Avoid too many return statements within this method.
      Open

                  return [ 'read' ];
      Severity: Major
      Found in repo/includes/Store/WikiPageEntityStorePermissionChecker.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return [ 'read', 'edit' ];
        Severity: Major
        Found in repo/includes/Store/WikiPageEntityStorePermissionChecker.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status