Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/rest-api/src/Application/UseCases/PatchItem/PatchedItemValidator.php

Summary

Maintainability
D
3 days
Test Coverage

File PatchedItemValidator.php has 399 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare( strict_types=1 );

namespace Wikibase\Repo\RestApi\Application\UseCases\PatchItem;

use LogicException;
Severity: Minor
Found in repo/rest-api/src/Application/UseCases/PatchItem/PatchedItemValidator.php - About 5 hrs to fix

    Method assertValidStatements has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function assertValidStatements( array $serialization, Item $originalItem, array $originalStatementsSerialization ): void {
        $validationError = $this->statementsValidator->validateModifiedStatements(
            $originalStatementsSerialization,
            $originalItem->getStatements(),
            $serialization['statements'] ?? [],
    Severity: Major
    Found in repo/rest-api/src/Application/UseCases/PatchItem/PatchedItemValidator.php - About 2 hrs to fix

      Method handleSitelinksValidationError has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function handleSitelinksValidationError( ValidationError $validationError, array $sitelinksSerialization ): void {
        $context = $validationError->getContext();
        $siteId = fn() => $context[ SitelinkValidator::CONTEXT_SITE_ID ];
        switch ( $validationError->getCode() ) {
            case SitelinksValidator::CODE_INVALID_SITELINK:
      Severity: Minor
      Found in repo/rest-api/src/Application/UseCases/PatchItem/PatchedItemValidator.php - About 1 hr to fix

        Method handleDescriptionsValidationError has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function handleDescriptionsValidationError( ValidationError $validationError ): void {
        $context = $validationError->getContext();

        switch ( $validationError->getCode() ) {
            case DescriptionsSyntaxValidator::CODE_DESCRIPTIONS_NOT_ASSOCIATIVE:
        Severity: Minor
        Found in repo/rest-api/src/Application/UseCases/PatchItem/PatchedItemValidator.php - About 1 hr to fix

          Method handleLabelsValidationError has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function handleLabelsValidationError( ValidationError $validationError ): void {
        $context = $validationError->getContext();

        switch ( $validationError->getCode() ) {
            case LabelsSyntaxValidator::CODE_LABELS_NOT_ASSOCIATIVE:
          Severity: Minor
          Found in repo/rest-api/src/Application/UseCases/PatchItem/PatchedItemValidator.php - About 1 hr to fix

            Method assertValidAliases has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function assertValidAliases( array $serialization ): void {
        $aliasesSerialization = $serialization[ 'aliases' ] ?? [];
        $validationError = $this->aliasesValidator->validate( $aliasesSerialization, '/aliases' );
        if ( $validationError ) {
            $errorCode = $validationError->getCode();
            Severity: Minor
            Found in repo/rest-api/src/Application/UseCases/PatchItem/PatchedItemValidator.php - About 1 hr to fix

              Method assertValidLabelsAndDescriptions has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function assertValidLabelsAndDescriptions( array $serialization, Item $originalItem ): void {
        $labels = $serialization['labels'] ?? [];
        $descriptions = $serialization['descriptions'] ?? [];
        $validationError = $this->labelsSyntaxValidator->validate( $labels, '/labels' ) ??
                           $this->descriptionsSyntaxValidator->validate( $descriptions, '/descriptions' ) ??
              Severity: Minor
              Found in repo/rest-api/src/Application/UseCases/PatchItem/PatchedItemValidator.php - About 1 hr to fix

                Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        LabelsSyntaxValidator $labelsSyntaxValidator,
        ItemLabelsContentsValidator $labelsContentsValidator,
        DescriptionsSyntaxValidator $descriptionsSyntaxValidator,
        ItemDescriptionsContentsValidator $descriptionsContentsValidator,
        AliasesValidator $aliasesValidator,
                Severity: Major
                Found in repo/rest-api/src/Application/UseCases/PatchItem/PatchedItemValidator.php - About 50 mins to fix

                  Function assertValidStatements has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function assertValidStatements( array $serialization, Item $originalItem, array $originalStatementsSerialization ): void {
        $validationError = $this->statementsValidator->validateModifiedStatements(
            $originalStatementsSerialization,
            $originalItem->getStatements(),
            $serialization['statements'] ?? [],
                  Severity: Minor
                  Found in repo/rest-api/src/Application/UseCases/PatchItem/PatchedItemValidator.php - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getStatementIdPath has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function getStatementIdPath( array $serialization, string $id ): string {
        foreach ( $serialization as $propertyId => $statementGroup ) {
            foreach ( $statementGroup as $groupIndex => $statement ) {
                if ( isset( $statement['id'] ) && $statement['id'] === $id ) {
                    return "/statements/$propertyId/$groupIndex";
                  Severity: Minor
                  Found in repo/rest-api/src/Application/UseCases/PatchItem/PatchedItemValidator.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      private function assertValidLabelsAndDescriptions( array $serialization, Item $originalItem ): void {
        $labels = $serialization['labels'] ?? [];
        $descriptions = $serialization['descriptions'] ?? [];
        $validationError = $this->labelsSyntaxValidator->validate( $labels, '/labels' ) ??
                           $this->descriptionsSyntaxValidator->validate( $descriptions, '/descriptions' ) ??
                  Severity: Major
                  Found in repo/rest-api/src/Application/UseCases/PatchItem/PatchedItemValidator.php and 1 other location - About 6 hrs to fix
                  repo/rest-api/src/Application/UseCases/PatchProperty/PatchedPropertyValidator.php on lines 119..144

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 204.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      public function __construct(
        LabelsSyntaxValidator $labelsSyntaxValidator,
        ItemLabelsContentsValidator $labelsContentsValidator,
        DescriptionsSyntaxValidator $descriptionsSyntaxValidator,
        ItemDescriptionsContentsValidator $descriptionsContentsValidator,
                  Severity: Major
                  Found in repo/rest-api/src/Application/UseCases/PatchItem/PatchedItemValidator.php and 3 other locations - About 1 hr to fix
                  client/includes/DataAccess/Scribunto/CachingFallbackBasedTermLookup.php on lines 63..79
                  client/includes/Hooks/OtherProjectsSidebarGeneratorFactory.php on lines 54..70
                  repo/rest-api/src/Application/Validation/ItemValidator.php on lines 28..44

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 116.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status