Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/rest-api/src/Infrastructure/EditSummaryFormatter.php

Summary

Maintainability
C
1 day
Test Coverage

Method convertToFormattableSummary has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function convertToFormattableSummary( EditSummary $editSummary ): FormatableSummary {
        switch ( true ) {
            case $editSummary instanceof PatchPropertyEditSummary:
                return $this->wholeEntityEditSummaryConverter->newSummaryForPropertyPatch( $editSummary );
Severity: Minor
Found in repo/rest-api/src/Infrastructure/EditSummaryFormatter.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                    return $this->wholeEntityEditSummaryConverter->newSummaryForItemPatch( $editSummary );
    Severity: Major
    Found in repo/rest-api/src/Infrastructure/EditSummaryFormatter.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $this->handleSitelinkEditSummary( $editSummary );
      Severity: Major
      Found in repo/rest-api/src/Infrastructure/EditSummaryFormatter.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $summary;
        Severity: Major
        Found in repo/rest-api/src/Infrastructure/EditSummaryFormatter.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $this->termsEditSummaryConverter->convertDescriptionsEditSummary( $editSummary );
          Severity: Major
          Found in repo/rest-api/src/Infrastructure/EditSummaryFormatter.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $this->termsEditSummaryConverter->convertAliasesEditSummary( $editSummary );
            Severity: Major
            Found in repo/rest-api/src/Infrastructure/EditSummaryFormatter.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $summary;
              Severity: Major
              Found in repo/rest-api/src/Infrastructure/EditSummaryFormatter.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return $this->handleStatementEditSummary( $editSummary );
                Severity: Major
                Found in repo/rest-api/src/Infrastructure/EditSummaryFormatter.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return $this->handleDescriptionEditSummary( $editSummary );
                  Severity: Major
                  Found in repo/rest-api/src/Infrastructure/EditSummaryFormatter.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return $this->newSummaryForAliasesInLanguageEdit( $editSummary );
                    Severity: Major
                    Found in repo/rest-api/src/Infrastructure/EditSummaryFormatter.php - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          private function handleDescriptionEditSummary( DescriptionEditSummary $editSummary ): FormatableSummary {
        switch ( $editSummary->getEditAction() ) {
            case EditSummary::ADD_ACTION:
                return $this->newSummaryForDescriptionEdit( $editSummary, 'add' );
            case EditSummary::REPLACE_ACTION:
                      Severity: Major
                      Found in repo/rest-api/src/Infrastructure/EditSummaryFormatter.php and 1 other location - About 1 hr to fix
                      repo/rest-api/src/Infrastructure/EditSummaryFormatter.php on lines 102..113

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 108.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          private function handleLabelEditSummary( LabelEditSummary $editSummary ): FormatableSummary {
        switch ( $editSummary->getEditAction() ) {
            case EditSummary::ADD_ACTION:
                return $this->newSummaryForLabelEdit( $editSummary, 'add' );
            case EditSummary::REPLACE_ACTION:
                      Severity: Major
                      Found in repo/rest-api/src/Infrastructure/EditSummaryFormatter.php and 1 other location - About 1 hr to fix
                      repo/rest-api/src/Infrastructure/EditSummaryFormatter.php on lines 115..126

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 108.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status