Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/rest-api/src/Infrastructure/SiteLinkLookupSitelinkValidator.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method validate has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function validate(
        ?string $itemId,
        string $siteId,
        array $sitelink,
        string $basePath = ''
Severity: Minor
Found in repo/rest-api/src/Infrastructure/SiteLinkLookupSitelinkValidator.php - About 1 hr to fix

    Function validate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function validate(
        ?string $itemId,
        string $siteId,
        array $sitelink,
        string $basePath = ''
    Severity: Minor
    Found in repo/rest-api/src/Infrastructure/SiteLinkLookupSitelinkValidator.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return new ValidationError(
                self::CODE_BADGE_NOT_ALLOWED,
                [ self::CONTEXT_VALUE => $e->getBadge(), self::CONTEXT_SITE_ID => $siteId ]
            );
    Severity: Major
    Found in repo/rest-api/src/Infrastructure/SiteLinkLookupSitelinkValidator.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return $this->checkSitelinkConflict( $itemId, $this->deserializedSitelink );
      Severity: Major
      Found in repo/rest-api/src/Infrastructure/SiteLinkLookupSitelinkValidator.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return new ValidationError( self::CODE_TITLE_NOT_FOUND, [ self::CONTEXT_SITE_ID => $siteId ] );
        Severity: Major
        Found in repo/rest-api/src/Infrastructure/SiteLinkLookupSitelinkValidator.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return new ValidationError(
                self::CODE_INVALID_BADGE,
                [ self::CONTEXT_VALUE => $e->getValue(), self::CONTEXT_SITE_ID => $siteId ]
            );
          Severity: Major
          Found in repo/rest-api/src/Infrastructure/SiteLinkLookupSitelinkValidator.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status