Sign upLogin

wikimedia/mediawiki-extensions-Wikibase

View on GitHub
Star
repo/rest-api/src/RouteHandlers/PatchPropertyStatementRouteHandler.php

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static function factory(): Handler {
        $responseFactory = new ResponseFactory();

        return new self(
            WbRestApi::getPatchPropertyStatement(),
Severity: Major
Found in repo/rest-api/src/RouteHandlers/PatchPropertyStatementRouteHandler.php and 1 other location - About 5 hrs to fix
repo/rest-api/src/RouteHandlers/PatchItemStatementRouteHandler.php on lines 59..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 183.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

    private function newSuccessHttpResponse( PatchStatementResponse $useCaseResponse ): Response {
        $httpResponse = $this->getResponseFactory()->create();
        $httpResponse->setStatus( 200 );
        $httpResponse->setHeader( 'Content-Type', 'application/json' );
        $httpResponse->setHeader(
Severity: Major
Found in repo/rest-api/src/RouteHandlers/PatchPropertyStatementRouteHandler.php and 5 other locations - About 2 hrs to fix
repo/rest-api/src/RouteHandlers/PatchItemStatementRouteHandler.php on lines 175..189
repo/rest-api/src/RouteHandlers/PatchStatementRouteHandler.php on lines 170..188
repo/rest-api/src/RouteHandlers/ReplaceItemStatementRouteHandler.php on lines 165..179
repo/rest-api/src/RouteHandlers/ReplacePropertyStatementRouteHandler.php on lines 164..178
repo/rest-api/src/RouteHandlers/ReplaceStatementRouteHandler.php on lines 160..174

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 132.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function runUseCase( string $propertyId, string $statementId ): Response {
        $requestBody = $this->getValidatedBody();
        '@phan-var array $requestBody'; // guaranteed to be an array per getBodyParamSettings()

        try {
Severity: Major
Found in repo/rest-api/src/RouteHandlers/PatchPropertyStatementRouteHandler.php and 2 other locations - About 2 hrs to fix
repo/rest-api/src/RouteHandlers/ReplacePropertyStatementRouteHandler.php on lines 94..115
repo/rest-api/src/RouteHandlers/SetPropertyDescriptionRouteHandler.php on lines 77..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 122.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status